<table><tr><td style="">zzag added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14081">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14081#inline-74171">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xcbeventlistener.cpp:135</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright"></span><span class="n"><span class="bright">xcb_generic_event_t</span></span><span style="color: #aa2211">*</span> <span class="n">e</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">static_cast</span><span style="color: #aa2211"><</span><span class="n">xcb_generic_event_t</span> <span style="color: #aa2211">*></span><span class="p">(</span><span class="n">message</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span style="color: #aa4000"><span class="bright">auto</span></span><span style="color: #aa2211">*</span> <span class="n">e</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">static_cast</span><span style="color: #aa2211"><</span><span class="n">xcb_generic_event_t</span> <span style="color: #aa2211">*></span><span class="p">(</span><span class="n">message</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">const</span> <span style="color: #aa4000">uint8_t</span> <span class="n">xEventType</span> <span style="color: #aa2211">=</span> <span class="n">e</span><span style="color: #aa2211">-></span><span class="n">response_type</span> <span style="color: #aa2211">&</span> <span style="color: #aa2211">~</span><span style="color: #601200">0x80</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">auto *e</tt></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14081#inline-74032">View Inline</a><span style="color: #4b4d51; font-weight: bold;">broulik</span> wrote in <span style="color: #4b4d51; font-weight: bold;">xcbeventlistener.cpp:151</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">I prefer to keep <tt style="background: #ebebeb; font-size: 13px;">*</tt> and <tt style="background: #ebebeb; font-size: 13px;">&</tt> even for when using <tt style="background: #ebebeb; font-size: 13px;">auto</tt></p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Also, keeping <tt style="background: #ebebeb; font-size: 13px;">*</tt> in some cases matter. For example,</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="cpp" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: #aa4000">int</span> <span class="n">x</span> <span style="color: #aa2211">=</span> <span style="color: #601200">42</span><span class="p">;</span>

<span style="color: #aa4000">const</span> <span style="color: #aa4000">auto</span> <span class="n">foo</span> <span style="color: #aa2211">=</span> <span style="color: #aa2211">&</span><span class="n">x</span><span class="p">;</span> <span style="color: #74777d">// foo has type of int* const</span>
<span style="color: #aa2211">*</span><span class="n">foo</span> <span style="color: #aa2211">=</span> <span style="color: #601200">43</span><span class="p">;</span> <span style="color: #74777d">// totally fine</span>

<span style="color: #aa4000">const</span> <span style="color: #aa4000">auto</span> <span style="color: #aa2211">*</span><span class="n">bar</span> <span style="color: #aa2211">=</span> <span style="color: #aa2211">&</span><span class="n">x</span><span class="p">;</span> <span style="color: #74777d">// bar has type of const int*</span>
<span style="color: #aa2211">*</span><span class="n">bar</span> <span style="color: #aa2211">=</span> <span style="color: #601200">43</span><span class="p">;</span> <span style="color: #74777d">// compilation error</span></pre></div></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R110 KScreen Library</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14081">https://phabricator.kde.org/D14081</a></div></div><br /><div><strong>To: </strong>gladhorn, Plasma<br /><strong>Cc: </strong>zzag, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>