<table><tr><td style="">kossebau added a subscriber: jriddell.<br />kossebau added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13930">View Revision</a></tr></table><br /><div><div><p>Thanks for offering this for inclusion. No time to test myself currently.</p>
<p>Important: can you tell what license space.com has on those images? Can they be used e.g. without a fee by 3rd-party software, like this plugin? I could not find a hint on the linked page on a quick look.</p>
<p>BTW, while I did some fixes to the potd dataengine , I am not the maintainer of it (nor plan to be). So it has to be someone else deciding about whether this plugin can be added.<br />
Given there seems no maintainer of this dataengine these days it would have to be the Plasma team in general, or the person overseeing things like the release manager (<a href="https://phabricator.kde.org/p/jriddell/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@jriddell</a>).</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13930#inline-73460">View Inline</a><span style="color: #4b4d51; font-weight: bold;">siodprovider.h:2-3</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d">/*</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> * Copyright (C) 2007 Tobias Koenig <tokoe@kde.org></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> * Copyright 2008 by Anne-Marie Mahfouf <annma@kde.org> </span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> *</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please update the copyright of all files, your name and the year is missing here.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13930#inline-73461">View Inline</a><span style="color: #4b4d51; font-weight: bold;">siodprovider.json:4</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #766510">"Description"</span><span style="color: #aa2211">:</span> <span style="color: #766510">"Siod Provider"</span><span style="color: #aa2211">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #766510">"Description[ca@valencia]"</span><span style="color: #aa2211">:</span> <span style="color: #766510">"Proveïdor Siod"</span><span style="color: #aa2211">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #766510">"Description[ca]"</span><span style="color: #aa2211">:</span> <span style="color: #766510">"Proveïdor Siod"</span><span style="color: #aa2211">,</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">The KDE translation system needs such in-source translations to be added to the translation database directly. This is a work done by the translator teams, but who first need to see the original string.<br />
The daily-run translation updating script (called scripty) will extract any strings to translate and update with strings from the translation database, but also remove any translations from the sources which are not in the database.<br />
So adding translations here directly will result in scripty removing them simply on next run. Thus no use to add them -> remove all here :)</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R114 Plasma Addons</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13930">https://phabricator.kde.org/D13930</a></div></div><br /><div><strong>To: </strong>tagorechandanreddy, Plasma, kossebau<br /><strong>Cc: </strong>jriddell, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>