<table><tr><td style="">broulik created this revision.<br />broulik added reviewers: Plasma, davidedmundson, fvogt.<br />Restricted Application added a project: Plasma.<br />Restricted Application added a subscriber: plasma-devel.<br />broulik requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13878">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Spotify web player uses a <tt style="background: #ebebeb; font-size: 13px;">video</tt> tag instead of <tt style="background: #ebebeb; font-size: 13px;">audio</tt> to play its music.<br />
We can do this as <tt style="background: #ebebeb; font-size: 13px;"><head></tt> is invisible by default and if a page wants to show the player in the page, it has to manually add it to the DOM anyway, but we add it before we even return it from <tt style="background: #ebebeb; font-size: 13px;">createElement</tt> so the order is correct here.</p>
<p>BUG: 395379</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Verified that you can <tt style="background: #ebebeb; font-size: 13px;">appendChild</tt> the same element to different elements and it just moves around instead of e.g. an "already attached to a parent" error<br />
I can control Spotify Web player now.<br />
When pressing play from the media controller, the title changes to the album name, as Spotify updates the page title only after the player started playing and we don't monitor the title tag yet, but this is unrelated to this patch<br />
Didn't notice anything unusual while casually browsing the web</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R856 Plasma Browser Integration</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13878">https://phabricator.kde.org/D13878</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>extension/content-script.js</div></div></div><br /><div><strong>To: </strong>broulik, Plasma, davidedmundson, fvogt<br /><strong>Cc: </strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>