<table><tr><td style="">broulik created this revision.<br />broulik added reviewers: Plasma, davidedmundson.<br />Restricted Application added a project: Plasma.<br />Restricted Application added a subscriber: plasma-devel.<br />broulik requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13852">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>There's no point in loading the entire module when automounting is disabled.<br />
It does Solid device queries which can be quite expensive, albeit it delays initialization.</p>

<p>The <tt style="background: #ebebeb; font-size: 13px;">AutomounterSettings::shouldAutomountDevice</tt> function allows force-mounting even if automounting as a whole is disabled whereas the KCM UI does not. Not sure what the reason for that is.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Enabled setting in KCM, kded module was loaded. Disabled setting in KCM, kded module was unloaded.<br />
Changed the rc file manually, started kded, it unloaded itself and didn't load again next time.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13852">https://phabricator.kde.org/D13852</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>solid-device-automounter/kcm/CMakeLists.txt<br />
solid-device-automounter/kcm/DeviceAutomounterKCM.cpp<br />
solid-device-automounter/kded/CMakeLists.txt<br />
solid-device-automounter/kded/DeviceAutomounter.cpp<br />
solid-device-automounter/kded/device_automounter.desktop</div></div></div><br /><div><strong>To: </strong>broulik, Plasma, davidedmundson<br /><strong>Cc: </strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>