<table><tr><td style="">zzag added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13591">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13591#inline-71118">View Inline</a><span style="color: #4b4d51; font-weight: bold;">breezesizegrip.cpp:54</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #74777d">// mask</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">QPolygon</span> <span class="n">p<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">;</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="bright"></span><span class="n"><span class="bright">p</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span> <span class="n">QPoint</span><span class="p">(</span> <span style="color: #601200">0</span><span class="p">,</span> <span class="n">GripSize</span> <span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">QPolygon</span> <span class="n">p<span class="bright"></span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span class="n"><span class="bright">QVector</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright"><</span></span><span class="bright"></span><span class="n"><span class="bright">QPoint</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">></span></span><span class="bright"></span><span class="p"><span class="bright">{</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="bright">   </span> <span class="n">QPoint</span><span class="p">(</span> <span style="color: #601200">0</span><span class="p">,</span> <span class="n">GripSize</span> <span class="p">)<span class="bright">,</span></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Can be const.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13591#inline-71119">View Inline</a><span style="color: #4b4d51; font-weight: bold;">breezesizegrip.cpp:150</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #74777d">// polygon</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">QPolygon</span> <span class="n">p<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">;</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="bright"></span><span class="n"><span class="bright">p</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span> <span class="n">QPoint</span><span class="p">(</span> <span style="color: #601200">0</span><span class="p">,</span> <span class="n">GripSize</span> <span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">QPolygon</span> <span class="n">p<span class="bright"></span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span class="n"><span class="bright">QVector</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright"><</span></span><span class="bright"></span><span class="n"><span class="bright">QPoint</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">></span></span><span class="bright"> </span><span class="p"><span class="bright">{</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="bright">   </span> <span class="n">QPoint</span><span class="p">(</span> <span style="color: #601200">0</span><span class="p">,</span> <span class="n">GripSize</span> <span class="p">)<span class="bright">,</span></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Can be const.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13591#inline-71122">View Inline</a><span style="color: #4b4d51; font-weight: bold;">breezeshadowhelper.cpp:461-464</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span style="color: #aa4000">const</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">int</span></span> <span class="n">topSize</span> <span style="color: #aa2211">=</span> <span class="n">margins</span><span class="p">.</span><span class="n">top</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span style="color: #aa4000">const</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">int</span></span> <span class="n">bottomSize</span> <span style="color: #aa2211">=</span> <span class="n">margins</span><span class="p">.</span><span class="n">bottom</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span style="color: #aa4000">const</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">int</span></span> <span style="color: #004012">leftSize</span><span class="p">(</span> <span class="n">margins</span><span class="p">.</span><span class="n">left</span><span class="p">()</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span style="color: #aa4000">const</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">int</span></span> <span style="color: #004012">rightSize</span><span class="p">(</span> <span class="n">margins</span><span class="p">.</span><span class="n">right</span><span class="p">()</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">const</span> <span class="bright"></span><span class="n"><span class="bright">quint32</span></span> <span class="n">topSize</span> <span style="color: #aa2211">=</span> <span class="n">margins</span><span class="p">.</span><span class="n">top</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">const</span> <span class="bright"></span><span class="n"><span class="bright">quint32</span></span> <span class="n">bottomSize</span> <span style="color: #aa2211">=</span> <span class="n">margins</span><span class="p">.</span><span class="n">bottom</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">const</span> <span class="bright"></span><span class="n"><span class="bright">quint32</span></span> <span style="color: #004012">leftSize</span><span class="p">(</span> <span class="n">margins</span><span class="p">.</span><span class="n">left</span><span class="p">()</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">const</span> <span class="bright"></span><span class="n"><span class="bright">quint32</span></span> <span style="color: #004012">rightSize</span><span class="p">(</span> <span class="n">margins</span><span class="p">.</span><span class="n">right</span><span class="p">()</span> <span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Not the best thing. But shadows in Breeze have positive margins so that's okay.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R31 Breeze</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13591">https://phabricator.kde.org/D13591</a></div></div><br /><div><strong>To: </strong>tcanabrava, Breeze<br /><strong>Cc: </strong>ngraham, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>