<table><tr><td style="">mart added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13372">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13372#inline-70413">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.qml:27</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">import</span> <span style="color: #004012">org</span><span class="p">.</span><span style="color: #004012">kde</span><span class="p">.</span><span style="color: #004012">kirigami</span> <span style="color: #601200">2.4</span> <span style="color: #004012">as</span> <span style="color: #004012">Kirigami</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #304a96">import</span> <span style="color: #004012">org</span><span class="p">.</span><span style="color: #004012">kde</span><span class="p">.</span><span style="color: #004012">plasma</span><span class="p">.</span><span style="color: #004012">core</span> <span style="color: #601200">2.0</span> <span style="color: #004012">as</span> <span style="color: #004012">PlasmaCore</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">never import anything from plasma in a kcm (an exception which we have to solve is SortFilterProxyModel)<br />
Kirigami has its own units</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13372#inline-70415">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.qml:199</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">implicitWidth:</span> <span style="color: #004012">units</span><span class="p">.</span><span style="color: #004012">gridUnit</span> <span style="color: #aa2211">*</span> <span style="color: #601200">9</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Kirigami.Units.gridUnit</p>
<p style="padding: 0; margin: 8px;">(tough controls shouldn't have explicit widths set)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13372#inline-70416">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.qml:220</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"> </span><span style="color: #004012">ExclGroup<span class="bright">Box</span></span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span style="color: #004012"><span class="bright">Controls</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span style="color: #004012">Excl<span class="bright">usive</span>Group</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">id: accelProfile</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">label:</span> <span style="color: #004012">i18n</span><span class="p">(</span><span style="color: #766510">"Acceleration Profile:"</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">model:</span> <span class="p">[</span><span style="color: #004012">i18n</span><span class="p">(</span><span style="color: #766510">"Flat"</span><span class="p">),</span> <span style="color: #004012">i18n</span><span class="p">(</span><span style="color: #766510">"Adaptive"</span><span class="p">)]</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">radiobuttons are auto exclusive now</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13372">https://phabricator.kde.org/D13372</a></div></div><br /><div><strong>To: </strong>furkantokac, ngraham, romangg, mart<br /><strong>Cc: </strong>safaalfulaij, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>