<table><tr><td style="">rkflx added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7087">View Revision</a></tr></table><br /><div><div><p>Thanks for the update and sorry it took me a while to look at it.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>If I remove that part, the button gets wider; I would prefer to keep it as small as possible.</p></blockquote>
<p>Ah, now I see where the problem is: You are inserting the button to a grid layout, which results in adding the button to the left of the logo (when looking at the left "columns" of the grid) instead of leaving the padding on the left alone and only adding it below the informational content and aligned to the left. This then causes the button to become wider.</p>
<p>By fixing the overall layout and adding appropriate spacers, you should be able to go without setting a <tt style="background: #ebebeb; font-size: 13px;">Fixed</tt> size policy for the button. Fixing the layout is required anyway, not sure why I didn't notice the huge gap on the left before. Try changing the window's width and compare to how it behaved before your patch to see what I mean.</p>
<p>I'd arrange the UI like this:</p>
<p><a href="https://phabricator.kde.org/F5885212" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F5885212: about-distro-layout.png</a></p>
<p>(Simply draw a selection rectangle around the labels, click on "Grid", align button with new spacer in horizontal layout, remove 2 spacers, click on "Vertical Layout", adjust size.)</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7087#inline-69157">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Module.cpp:260</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">ui</span><span style="color: #aa2211">-></span><span class="n">nameVersionLabel</span><span style="color: #aa2211">-></span><span class="n">isHidden</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">text</span> <span style="color: #aa2211">+=</span> <span class="n">i18nc</span><span class="p">(</span><span style="color: #766510">"one line in the information that goes to the clipboard"</span><span class="p">,</span> <span style="color: #766510">"%1: %2"</span><span class="p">,</span> <span class="n">i18nc</span><span class="p">(</span><span style="color: #766510">"label in the Copy to Clipboard button"</span><span class="p">,</span> <span style="color: #766510">"Distro"</span><span class="p">),</span> <span class="n">ui</span><span style="color: #aa2211">-></span><span class="n">nameVersionLabel</span><span style="color: #aa2211">-></span><span class="n">text</span><span class="p">())</span> <span style="color: #aa2211">+</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"</span><span style="color: #bb6622">\n</span><span style="color: #766510">"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Maybe you could avoid this special case if you added a hidden label in <tt style="background: #ebebeb; font-size: 13px;">loadSoftware</tt>?</p>
<p style="padding: 0; margin: 8px;">Also, "label in … the button" sounds a bit odd. Perhaps "label" would be enough, or use <tt style="background: #ebebeb; font-size: 13px;">@title:row</tt>? (See <a href="https://api.kde.org/frameworks/ki18n/html/prg_guide.html" class="remarkup-link" target="_blank" rel="noreferrer">https://api.kde.org/frameworks/ki18n/html/prg_guide.html</a>)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7087#inline-69155">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Module.cpp:263</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">foreach</span> <span class="p">(</span><span style="color: #aa4000">auto</span> <span class="n">p</span><span class="p">,</span> <span class="n">labelsForClipboard</span><span class="p">)</span> <span class="p">{</span> <span style="color: #74777d">// note that does not necessarily represent the same order as in the GUI</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">auto</span> <span class="n">descriptionLabelText</span> <span style="color: #aa2211">=</span> <span class="n">p</span><span class="p">.</span><span class="n">first</span><span style="color: #aa2211">-></span><span class="n">text</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I'd use the C++11 <tt style="background: #ebebeb; font-size: 13px;">for ( : )</tt> here, and add <tt style="background: #ebebeb; font-size: 13px;">qAsConst</tt> to the second argument since we can depend on Qt 5.7.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7087#inline-69153">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Module.cpp:268</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">valueLabel</span><span style="color: #aa2211">-></span><span class="n">isHidden</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">descriptionLabelText</span><span class="p">.</span><span class="n">endsWith</span><span class="p">(</span><span style="color: #766510">":"</span><span class="p">))</span> <span class="p">{</span> <span style="color: #74777d">// strip colon from the end</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">descriptionLabelText</span> <span style="color: #aa2211">=</span> <span class="n">descriptionLabelText</span><span class="p">.</span><span class="n">left</span><span class="p">(</span><span class="n">descriptionLabelText</span><span class="p">.</span><span class="n">length</span><span class="p">()</span> <span style="color: #aa2211">-</span> <span style="color: #601200">1</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Is <tt style="background: #ebebeb; font-size: 13px;">endsWith</tt> RTL aware? If not, it might be better to also check <tt style="background: #ebebeb; font-size: 13px;">startsWith</tt>, however that assumes in most languages <tt style="background: #ebebeb; font-size: 13px;">:</tt> is kept intact, which I'm not sure about.</p>
<p style="padding: 0; margin: 8px;">Thinking about this again, why not</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">keep the colon in the label</li>
<li class="remarkup-list-item">don't add a colon in <tt style="background: #ebebeb; font-size: 13px;">%1 %2</tt></li>
<li class="remarkup-list-item">change the context to <tt style="background: #ebebeb; font-size: 13px;">%1 is a label already including a colon, …</tt></li>
</ul></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7087#inline-69152">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Module.cpp:271</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">text</span> <span style="color: #aa2211">+=</span> <span class="n">i18nc</span><span class="p">(</span><span style="color: #766510">"one line in the information that goes to the clipboard"</span><span class="p">,</span> <span style="color: #766510">"%1: %2"</span><span class="p">,</span> <span class="n">descriptionLabelText</span><span class="p">,</span> <span class="n">valueLabelText</span><span class="p">)</span> <span style="color: #aa2211">+</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"</span><span style="color: #bb6622">\n</span><span style="color: #766510">"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p style="padding: 0; margin: 8px;">explain what the placeholders are meant to be. Leave it to the speakers of the language the decision about the order.</p></blockquote>
<p style="padding: 0; margin: 8px;">I suspect <a href="https://phabricator.kde.org/p/ltoscano/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@ltoscano</a> meant something like this:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">%1 is a label, %2 is a corresponding value</pre></div>
<p style="padding: 0; margin: 8px;">"One line" is meaningless unless the translator also knows the other lines, and whether it is saved to the clipboard or a text file is probably also more confusing than helping.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7087#inline-68577">View Inline</a><span style="color: #4b4d51; font-weight: bold;">gregormi</span> wrote in <span style="color: #4b4d51; font-weight: bold;">Module.ui:333-338</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">If I remove that part, the button gets wider; I would prefer to keep it as small as possible.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">See reply in main comment.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7087#inline-68581">View Inline</a><span style="color: #4b4d51; font-weight: bold;">gregormi</span> wrote in <span style="color: #4b4d51; font-weight: bold;">Module.ui:349-351</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">The KStandardAction method seems only easily applicable with QToolButtons but not with QPushButton. Furthermore, I got the "ambiguous key binding" when I tried it. I now settled for QKeySequence::Copy which does not work for me but at least results in no error message.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Works perfectly fine for me. I think there might be something off with your local shortcuts setup.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R102 KInfoCenter</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D7087">https://phabricator.kde.org/D7087</a></div></div><br /><div><strong>To: </strong>gregormi, ngraham, dhaumann, rkflx<br /><strong>Cc: </strong>rkflx, dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart<br /></div>