<table><tr><td style="">zzag added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13192">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13192#inline-68465">View Inline</a><span style="color: #4b4d51; font-weight: bold;">FullRepresentation.qml:439</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #74777d">// pointer motion vector.</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">if</span> <span class="p">((</span><span style="color: #304a96">Math</span><span class="p">.</span><span style="color: #004012">abs</span><span class="p">(</span><span style="color: #004012">dx</span><span class="p">)</span> <span style="color: #aa2211">+</span> <span style="color: #304a96">Math</span><span class="p">.</span><span style="color: #004012">abs</span><span class="p">(</span><span style="color: #004012">dy</span><span class="p">))</span> <span style="color: #aa2211">></span> <span style="color: #004012">Qt</span><span class="p">.</span><span style="color: #004012">styleHints</span><span class="p">.</span><span style="color: #004012">startDragDistance</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #004012">tabBar</span><span class="p">.</span><span style="color: #004012">currentTab</span> <span style="color: #aa2211">!=</span> <span style="color: #004012">button</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I believe it's possible to reduce indentation. E.g.</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="js" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: #aa4000">if</span> <span class="p">((</span><span style="color: #304a96">Math</span><span class="p">.</span><span style="color: #004012">abs</span><span class="p">(</span><span style="color: #004012">dx</span><span class="p">)</span> <span style="color: #aa2211">+</span> <span style="color: #304a96">Math</span><span class="p">.</span><span style="color: #004012">abs</span><span class="p">(</span><span style="color: #004012">dy</span><span class="p">))</span> <span style="color: #aa2211"><=</span> <span style="color: #004012">Qt</span><span class="p">.</span><span style="color: #004012">styleHints</span><span class="p">.</span><span style="color: #004012">startDragDistance</span><span class="p">)</span> <span class="p">{</span>
    <span style="color: #aa4000">return</span><span class="p">;</span>
<span class="p">}</span>

<span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #004012">tabBar</span><span class="p">.</span><span style="color: #004012">currentTab</span> <span style="color: #aa2211">==</span> <span style="color: #004012">button</span><span class="p">)</span> <span class="p">{</span>
    <span style="color: #004012">oldPos</span> <span style="color: #aa2211">=</span> <span style="color: #004012">Qt</span><span class="p">.</span><span style="color: #004012">point</span><span class="p">(</span><span style="color: #004012">mouse</span><span class="p">.</span><span style="color: #004012">x</span><span class="p">,</span> <span style="color: #004012">mouse</span><span class="p">.</span><span style="color: #004012">y</span><span class="p">);</span>
    <span style="color: #aa4000">return</span><span class="p">;</span>
<span class="p">}</span>

<span style="color: #aa4000">var</span> <span style="color: #004012">tabBarPos</span> <span style="color: #aa2211">=</span> <span style="color: #004012">mapToItem</span><span class="p">(</span><span style="color: #004012">tabBar</span><span class="p">,</span> <span style="color: #004012">oldPos</span><span class="p">.</span><span style="color: #004012">x</span><span class="p">,</span> <span style="color: #004012">oldPos</span><span class="p">.</span><span style="color: #004012">y</span><span class="p">);</span>
<span style="color: #74777d">// ...</span></pre></div></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13192">https://phabricator.kde.org/D13192</a></div></div><br /><div><strong>To: </strong>hein, ngraham, davidedmundson, rkflx, cfeck<br /><strong>Cc: </strong>zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>