<table><tr><td style="">rkflx added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10297">View Revision</a></tr></table><br /><div><div><p>Great, looking much better than before. As far as I can see the inline comments are done.</p>
<blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D10297#229850" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D10297#229850</a>, <a href="https://phabricator.kde.org/p/rkflx/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@rkflx</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><ul class="remarkup-list">
<li class="remarkup-list-item">The text should use title case: "Kill a Window"</li>
</ul></div>
</blockquote>
<p>Not done.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><ul class="remarkup-list">
<li class="remarkup-list-item">The shortcut does not get localized. (In the global shortcuts KCM, it is localized correctly for me.)</li>
<li class="remarkup-list-item">The parentheses look a bit ugly, in normal menus the shortcuts are simply aligned to the right (not sure how that's done, though).</li>
<li class="remarkup-list-item">At least for <span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">Run Command</span></span></span> the shortcut should be shown (just like in the desktop context menu).</li>
</ul></blockquote>
<p>Are those points impossible to achieve? At least in other places they seem to work…</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10297#inline-66397">View Inline</a><span style="color: #4b4d51; font-weight: bold;">gregormi</span> wrote in <span style="color: #4b4d51; font-weight: bold;">ksysguardprocesslist.cpp:412</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Interesting. This indeed returns "org.kde.ksysguard". Do you have an idea, how Qt knows this desktop name? The only occurrences of this string in the ksysguard project are:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">gui/CMakeLists.txt: install( PROGRAMS org.kde.ksysguard.desktop DESTINATION ${KDE_INSTALL_APPDIR} )</li>
<li class="remarkup-list-item">and gui/org.kde.ksysguard.desktop itself.</li>
</ul></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Interesting question ;)</p>
<p style="padding: 0; margin: 8px;">After looking into Qt's sources for <a href="https://code.woboq.org/qt5/qtbase/src/gui/kernel/qguiapplication.cpp.html#_ZN15QGuiApplication15desktopFileNameEv" class="remarkup-link" target="_blank" rel="noreferrer"><tt style="background: #ebebeb; font-size: 13px;">desktopFileName</tt></a>, I set a breakpoint on <tt style="background: #ebebeb; font-size: 13px;">QGuiApplication::setDesktopFileName</tt>, and ended up in <a href="https://code.woboq.org/qt5/kf5/kcoreaddons/src/lib/kaboutdata.cpp.html#_ZN10KAboutData18setApplicationDataERKS_" class="remarkup-link" target="_blank" rel="noreferrer"><tt style="background: #ebebeb; font-size: 13px;">KAboutData::setApplicationData</tt></a>.</p>
<p style="padding: 0; margin: 8px;">In <tt style="background: #ebebeb; font-size: 13px;">ksysguard.cpp</tt> you then have</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">KAboutData aboutData( QStringLiteral("ksysguard"), …
…
QStringLiteral("ksysguard")aboutData.setOrganizationDomain(QByteArray("kde.org"));</pre></div>
<p style="padding: 0; margin: 8px;">…which looks related (did not check in detail, though).</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R111 KSysguard Library</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10297">https://phabricator.kde.org/D10297</a></div></div><br /><div><strong>To: </strong>gregormi, Plasma, colomar, kossebau, broulik, mart, hein<br /><strong>Cc: </strong>apol, anthonyfieroni, andreaska, rkflx, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart<br /></div>