<table><tr><td style="">rkflx added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12849">View Revision</a></tr></table><br /><div><div><p>The checkboxes wildly floating around on the left look a bit weird to me. How about this (I guess your original intention was to avoid having checkboxes under the wrong text label?):</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">Anti-Aliasing: Enabled
[ ] Exclude range from 8pt to 15pt
(…)
Fonts DPI: [ ] Force to 96 dpi</pre></div>
<hr class="remarkup-hr" />
<p>A more general comment: Compared to the state before the redesign, the dialog now looks like two separate KCMs slapped together, as can be seen by the need to include two title headers and the separating line. Also, the settings on the top are easily understandable by any word processor user, while the terminology on the bottom requires more expert knowledge.</p>
<p>It might be worth thinking about a different way to group both sections. I'm not suggesting going back to the modal dialog, but maybe group boxes, two tabs, or a <tt style="background: #ebebeb; font-size: 13px;">KCollapsibleGroupBox</tt> would be better?</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>BRANCH</strong><div><div>fonts_kcm_layout (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12849">https://phabricator.kde.org/D12849</a></div></div><br /><div><strong>To: </strong>progwolff, mart, abetts, ngraham<br /><strong>Cc: </strong>rkflx, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>