<table><tr><td style="">mart added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12563">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D12563#257052" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D12563#257052</a>, <a href="https://phabricator.kde.org/p/dscheffer/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@dscheffer</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D12563#257024" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D12563#257024</a>, <a href="https://phabricator.kde.org/p/broulik/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@broulik</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Urgh. Just because you can doesn't mean you should. This will horribly break if the user is running a different look and feel package (different form factor, distro branding, etc).</p>
<p>Please have a look at the "Search" plasmoid in milou which is basically a KRunner applet. Perhaps you can improve and/or base your work on that one instead.</p></div>
</blockquote>
<p>Thanks for pointing that out! I will have a look at milou. But just out of curiosity: Will krunner break with other look and feel packages as well? As far as I can tell it does the same as I did since I got the idea from there. (see lines 93-100 in <a href="https://github.com/KDE/plasma-workspace/blob/master/krunner/view.cpp" class="remarkup-link" target="_blank" rel="noreferrer">https://github.com/KDE/plasma-workspace/blob/master/krunner/view.cpp</a>)</p></div>
</blockquote>
<p>krunner is done to in theory have different uis on different look and feel packages.. if the theme wants it.<br />
right now none of them implement their own krunner, but they can (somewhere there is one that implements a kde4 style ui for it iirc)</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12563">https://phabricator.kde.org/D12563</a></div></div><br /><div><strong>To: </strong>dscheffer, broulik<br /><strong>Cc: </strong>mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>