<table><tr><td style="">mlibera updated this revision to Diff 33433.<br />mlibera edited the summary of this revision. <a href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-hxeyk7w2wukd23t/">(Show Details)</a><br />mlibera added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12641">View Revision</a></tr></table><br /><div><div><p><a href="https://phabricator.kde.org/p/anthonyfieroni/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@anthonyfieroni</a><br />
I think it makes sense, I've tested it and it works.</p>
<p><a href="https://phabricator.kde.org/p/bruns/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@bruns</a><br />
I've tried to mimic the code that was already there.<br />
With this revised version there is no extra code, so I guess no need for comments?<br />
I've never used phabricator and have no idea what parent revision is or what am I expected to do with it, sorry.</p></div></div><br /><div><strong>CHANGES TO REVISION SUMMARY</strong><div><div style="white-space: pre-wrap; color: #74777D;">For some reason a <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">signal is being received about a device finishing setup</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">Solid::StorageAccess::setupDone signal can be</span><br />
<span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">received </span>before <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">it'</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">a device i</span>s actually mounted, resulting in kde-open5<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);"> being called with</span><br />
<span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">being called with </span>and empty path instead of a mount point.<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);"> This doesn't fix the underlying</span><br />
<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">issue but works around it by double checking if a device is really</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">Replace signal setupDone with accessibilityChanged to make sure</span><br />
<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">mounted and if not waiting for it</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">that a mount point exists</span>.<div style="padding: 8px 0;">...</div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D12641?vs=33414&id=33433">https://phabricator.kde.org/D12641?vs=33414&id=33433</a></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12641">https://phabricator.kde.org/D12641</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>soliduiserver/deviceserviceaction.cpp</div></div></div><br /><div><strong>To: </strong>mlibera, Plasma, broulik, Frameworks<br /><strong>Cc: </strong>anthonyfieroni, bruns, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>