<table><tr><td style="">bruns added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12498">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12498#inline-63602">View Inline</a><span style="color: #4b4d51; font-weight: bold;">AuthDialog.cpp:345</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #74777d">// neither isEmpty() or isNull() worked (?)</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">actionDescription</span><span class="p">.</span><span class="n">description</span><span class="p">()</span> <span style="color: #aa2211">==</span> <span style="color: #766510">""</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">QFont</span> <span class="n">descrFont</span><span class="p">(</span><span class="n">action_label</span><span style="color: #aa2211">-></span><span class="n">font</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;"> == ""</tt> should be identical to .isEmpty(), please recheck</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12498#inline-63603">View Inline</a><span style="color: #4b4d51; font-weight: bold;">AuthDialog.cpp:349</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">action_label</span><span style="color: #aa2211">-></span><span class="n">setFont</span><span class="p">(</span><span class="n">descrFont</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">action_label</span><span style="color: #aa2211">-></span><span class="n">setText</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Not A<span class="bright">pplic</span>able"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">action_label</span><span style="color: #aa2211">-></span><span class="n">setText</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Not A<span class="bright">vail</span>able"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="p">}</span> <span style="color: #aa4000">else</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">According to <a href="https://www.freedesktop.org/software/polkit/docs/latest/polkit.8.html#polkit-rules" class="remarkup-link" target="_blank" rel="noreferrer">https://www.freedesktop.org/software/polkit/docs/latest/polkit.8.html#polkit-rules</a><br />
<tt style="background: #ebebeb; font-size: 13px;">description</tt> is not optional, so the correct statement is "Missing"</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12498#inline-63604">View Inline</a><span style="color: #4b4d51; font-weight: bold;">authdetails.ui:26</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">     <property name="text">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">      <string>Action:</string>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">      <string>Action<span class="bright"> ID</span>:</string>
</div><div style="padding: 0 8px; margin: 0 4px; ">     </property>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I think "ID" is sufficient</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R121 Policykit (Polkit) KDE Agent</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12498">https://phabricator.kde.org/D12498</a></div></div><br /><div><strong>To: </strong>sharvey, bruns, ngraham, davidedmundson<br /><strong>Cc: </strong>davidedmundson, bruns, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>