<table><tr><td style="">broulik added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8626">View Revision</a></tr></table><br /><div><div><p>lgtm</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8626#inline-61839">View Inline</a><span style="color: #4b4d51; font-weight: bold;">CMakeLists.txt:58</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> find_package(DDCUtil)
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> find_package(DDCUtil<span class="bright"> REQUIRED</span>)
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> add_definitions(-DWITH_DDCUTIL)
</div><div style="padding: 0 8px; margin: 0 4px; "> set_package_properties(DDCUtil
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">we typically use <tt style="background: #ebebeb; font-size: 13px;">HAVE_xxx</tt> but fine with me</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8626#inline-61840">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ddcutilbrightness.h:27</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #304a96">#if<span class="bright">def</span> WITH_DDCUTIL</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">#if WITH_DDCUTIL</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #304a96">#include</span> <span class="cpf"><ddcutil_c_api.h></span><span style="color: #304a96"></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Doesn't this need to stay <tt style="background: #ebebeb; font-size: 13px;">ifdef</tt>?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R122 Powerdevil</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D8626">https://phabricator.kde.org/D8626</a></div></div><br /><div><strong>To: </strong>dvogel, broulik, davidedmundson<br /><strong>Cc: </strong>asturmlechner, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>