<table><tr><td style="">broulik added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D11584">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D11584#inline-57389">View Inline</a><span style="color: #4b4d51; font-weight: bold;">StatusNotifierItem.qml:63</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">onClicked:</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span style="color: #aa4000">var</span> <span style="color: #004012">pos</span> <span style="color: #aa2211">=</span> <span style="color: #004012">plasmoid</span><span class="p">.</span><span style="color: #004012">nativeInterface</span><span class="p">.</span><span style="color: #004012">popupPosition</span><span class="p">(</span><span style="color: #004012">taskIcon</span><span class="p">,</span> <span class="bright"></span><span style="color: #601200"><span class="bright">0</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">0</span></span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">var</span> <span style="color: #004012">pos</span> <span style="color: #aa2211">=</span> <span style="color: #004012">plasmoid</span><span class="p">.</span><span style="color: #004012">nativeInterface</span><span class="p">.</span><span style="color: #004012">popupPosition</span><span class="p">(</span><span style="color: #004012">taskIcon</span><span class="p">,</span> <span class="bright"></span><span style="color: #004012"><span class="bright">mouse</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">x</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">mouse</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">y</span></span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I think this change is fine. Except that the <tt style="background: #ebebeb; font-size: 13px;">MouseArea</tt> covers the entire list item, so for hidden SNIs the app might get coordinates outside of its icon.</p>

<p style="padding: 0; margin: 8px;">For context menu we ignore the coordinates anyway and place the menu relative to the icon (so it never covers it). For <tt style="background: #ebebeb; font-size: 13px;">Activate</tt> the app might want to know where it was clicked. In any case this needs a bit of cleaning up, we pass parameters around in places where they're ignored and so on.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D11584">https://phabricator.kde.org/D11584</a></div></div><br /><div><strong>To: </strong>fvogt, Plasma<br /><strong>Cc: </strong>broulik, davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>