<table><tr><td style="">fvogt added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D11447">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D11447#229334" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D11447#229334</a>, <a href="https://phabricator.kde.org/p/graesslin/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@graesslin</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D11447#229128" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D11447#229128</a>, <a href="https://phabricator.kde.org/p/fvogt/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@fvogt</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>If <tt style="background: #ebebeb; font-size: 13px;">KWorkSpace::detectPlatform(argc, argv);</tt> were changed to edit <tt style="background: #ebebeb; font-size: 13px;">argc</tt> and <tt style="background: #ebebeb; font-size: 13px;">argv</tt> to pass <tt style="background: #ebebeb; font-size: 13px;">-platform foo</tt> instead of setting <tt style="background: #ebebeb; font-size: 13px;">QT_QPA_PLATFORM</tt>, the <tt style="background: #ebebeb; font-size: 13px;">qunsetenv</tt> calls would become unnecessary.</p></div>
</blockquote>
<p>but that sounds rather dangerous. I don't want to mess with the command line arguments</p></div>
</blockquote>
<p>Why is that more dangerous than environment variables?<br />
If argc and argv are passed to <tt style="background: #ebebeb; font-size: 13px;">QApplication</tt>, you already know how it'll be parsed.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>BRANCH</strong><div><div>unset-qt-qpa-platform</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D11447">https://phabricator.kde.org/D11447</a></div></div><br /><div><strong>To: </strong>graesslin, Plasma, davidedmundson<br /><strong>Cc: </strong>fvogt, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>