<table><tr><td style="">ngraham added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D11308">View Revision</a></tr></table><br /><div><div><p>I strongly agree that this UI needs more background contrast, and I volunteer to spearhead the initiative to improve that (<a href="https://bugs.kde.org/show_bug.cgi?id=369676" class="remarkup-link" target="_blank" rel="noreferrer">https://bugs.kde.org/show_bug.cgi?id=369676</a>)</p>
<p>However, this patch as is doesn't <em>require</em> that. We as the upstream vendor have control over the default--and the default looks good and has sufficient contrast:</p>
<p>Screenshot:<br />
<a href="https://phabricator.kde.org/F5753279" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F5753279: KScreenLocker.png</a></p>
<p>Real-world, on my wife's laptop:<br />
<a href="https://phabricator.kde.org/F5687394" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F5687394: IMG_0792.jpg</a></p>
<p>As downstream vendors, distros will also have a responsibility to ensure that the contrast is sufficient until <a href="https://bugs.kde.org/show_bug.cgi?id=369676" class="remarkup-link" target="_blank" rel="noreferrer">https://bugs.kde.org/show_bug.cgi?id=369676</a> is resolved (which again I will commit to getting done). Since this change would go into 5.13, for quite some time the only distros that could possibly be affected will be rolling release distros. <a href="https://phabricator.kde.org/p/graesslin/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@graesslin</a>, if you can find it in your heart to approve this, I will commit to reaching out to them and helping them make any necessary adjustments.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R133 KScreenLocker</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D11308">https://phabricator.kde.org/D11308</a></div></div><br /><div><strong>To: </strong>ngraham, Plasma, VDG, graesslin, abetts<br /><strong>Cc: </strong>davidedmundson, zzag, Pitel, progwolff, abetts, hein, mart, graesslin, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol<br /></div>