<table><tr><td style="">Pitel added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D11352">View Revision</a></tr></table><br /><div><div><p>I guess Phabricator does not let me only respond to inline comments.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D11352#inline-55868">View Inline</a><span style="color: #4b4d51; font-weight: bold;">mart</span> wrote in <span style="color: #4b4d51; font-weight: bold;">main.qml:65</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">as convention we usually don't have getFoo as names (and this is not getting a property anyways)<br />
i would like a more descriptive name like indexForCategory and have the category as parameter instead of the item</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">What about <tt style="background: #ebebeb; font-size: 13px;">indexForItemCategory</tt>? I need to pass in item not category because of special treatment of notifications.</p>
<p style="padding: 0; margin: 8px;">Also I'll rename <tt style="background: #ebebeb; font-size: 13px;">itemCompare</tt> to <tt style="background: #ebebeb; font-size: 13px;">compareItems</tt>.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D11352">https://phabricator.kde.org/D11352</a></div></div><br /><div><strong>To: </strong>Pitel<br /><strong>Cc: </strong>wsdfhjxc, mart, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>