<table><tr><td style="">Pitel updated this revision to Diff 29457.<br />Pitel added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D11292">View Revision</a></tr></table><br /><div><div><ul class="remarkup-list">
<li class="remarkup-list-item">modified <tt style="background: #ebebeb; font-size: 13px;">onConfigurationChanged</tt> so it triggers updates of properties depending on <tt style="background: #ebebeb; font-size: 13px;">cfg_shownItems</tt> and <tt style="background: #ebebeb; font-size: 13px;">cfg_hiddenItems</tt></li>
<li class="remarkup-list-item">make trash bin not draggable</li>
<li class="remarkup-list-item">removed <tt style="background: #ebebeb; font-size: 13px;">ComboBox</tt> hack (which was not working anyway) and added an overlay label to combobox showing <tt style="background: #ebebeb; font-size: 13px;">S</tt> for items in <tt style="background: #ebebeb; font-size: 13px;">cfg_shownItems</tt> and <tt style="background: #ebebeb; font-size: 13px;">H</tt> for items in <tt style="background: #ebebeb; font-size: 13px;">cfg_hiddenItems</tt> (this is meant as debugging tool only) -- when dragging the visibility values in comboboxes go wrong but those letter remain correct which leads me to conclusion that the problem is <tt style="background: #ebebeb; font-size: 13px;">ComboBox</tt> component (<a href="https://phabricator.kde.org/p/wsdfhjxc/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@wsdfhjxc</a> can you verify this behavior?)</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D11292?vs=29421&id=29457">https://phabricator.kde.org/D11292?vs=29421&id=29457</a></div></div><br /><div><strong>BRANCH</strong><div><div>stableSystray</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D11292">https://phabricator.kde.org/D11292</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>applets/systemtray/package/contents/config/main.xml<br />
applets/systemtray/package/contents/ui/ConfigEntries.qml<br />
applets/systemtray/package/contents/ui/OrderableItem.qml<br />
applets/systemtray/package/contents/ui/items/AbstractItem.qml<br />
applets/systemtray/package/contents/ui/main.qml</div></div></div><br /><div><strong>To: </strong>Pitel, Plasma, VDG<br /><strong>Cc: </strong>zzag, davidedmundson, anthonyfieroni, wsdfhjxc, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>