<table><tr><td style="">mart added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D11262">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D11262#inline-55145">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Logout.qml:87</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">function</span> <span class="bright"></span><span style="color: #004012"><span class="bright">rgbToHsv</span></span><span class="p">(</span><span style="color: #004012">color</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">var</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">max</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span> <span style="color: #304a96">Math</span><span class="p">.</span><span style="color: #004012">max</span><span class="p">(</span><span style="color: #004012">color</span><span class="p">.</span><span style="color: #004012">r</span><span class="p">,</span> <span style="color: #004012">color</span><span class="p">.</span><span style="color: #004012">g</span><span class="p">,</span> <span style="color: #004012">color</span><span class="p">.</span><span style="color: #004012">b</span><span class="p">)<span class="bright">;</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">var</span> <span style="color: #004012">min</span> <span style="color: #aa2211">=</span> <span style="color: #304a96">Math</span><span class="p">.</span><span style="color: #004012">min</span><span class="p">(</span><span style="color: #004012">color</span><span class="p">.</span><span style="color: #004012">r</span><span class="p">,</span> <span style="color: #004012">color</span><span class="p">.</span><span style="color: #004012">g</span><span class="p">,</span> <span style="color: #004012">color</span><span class="p">.</span><span style="color: #004012">b</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">var</span> <span style="color: #004012">d</span> <span style="color: #aa2211">=</span> <span style="color: #004012">max</span> <span style="color: #aa2211">-</span> <span style="color: #004012">min</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">var</span> <span style="color: #004012">h</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">var</span> <span style="color: #004012">s</span> <span style="color: #aa2211">=</span> <span class="p">(</span><span style="color: #004012">max</span> <span style="color: #aa2211">===</span> <span style="color: #601200">0</span> <span style="color: #aa2211">?</span> <span style="color: #601200">0</span> <span style="color: #aa2211">:</span> <span style="color: #004012">d</span> <span style="color: #aa2211">/</span> <span style="color: #004012">max</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">var</span> <span style="color: #004012">v</span> <span style="color: #aa2211">=</span> <span style="color: #004012">max</span> <span style="color: #aa2211">/</span> <span style="color: #601200">255</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">switch</span> <span class="p">(</span><span style="color: #004012">max</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">case</span> <span style="color: #aa4000">min:</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #004012">h</span> <span style="color: #aa2211">=</span> <span style="color: #601200">0</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">break</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">case</span> <span style="color: #aa4000">color.r:</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #004012">h</span> <span style="color: #aa2211">=</span> <span class="p">(</span><span style="color: #004012">color</span><span class="p">.</span><span style="color: #004012">g</span> <span style="color: #aa2211">-</span> <span style="color: #004012">color</span><span class="p">.</span><span style="color: #004012">b</span><span class="p">)</span> <span style="color: #aa2211">+</span> <span style="color: #004012">d</span> <span style="color: #aa2211">*</span> <span class="p">(</span><span style="color: #004012">color</span><span class="p">.</span><span style="color: #004012">g</span> <span style="color: #aa2211"><</span> <span style="color: #004012">color</span><span class="p">.</span><span style="color: #004012">b</span> <span style="color: #aa2211">?</span> <span style="color: #601200">6</span><span style="color: #aa2211">:</span> <span style="color: #601200">0</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #004012">h</span> <span style="color: #aa2211">/=</span> <span style="color: #601200">6</span> <span style="color: #aa2211">*</span> <span style="color: #004012">d</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">break</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">case</span> <span style="color: #aa4000">color.g:</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #004012">h</span> <span style="color: #aa2211">=</span> <span class="p">(</span><span style="color: #004012">color</span><span class="p">.</span><span style="color: #004012">b</span> <span style="color: #aa2211">-</span> <span style="color: #004012">color</span><span class="p">.</span><span style="color: #004012">r</span><span class="p">)</span> <span style="color: #aa2211">+</span> <span style="color: #004012">d</span> <span style="color: #aa2211">*</span> <span style="color: #601200">2</span><span class="p">;</span> <span style="color: #004012">h</span> <span style="color: #aa2211">/=</span> <span style="color: #601200">6</span> <span style="color: #aa2211">*</span> <span style="color: #004012">d</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">break</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">case</span> <span style="color: #aa4000">color.b:</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #004012">h</span> <span style="color: #aa2211">=</span> <span class="p">(</span><span style="color: #004012">color</span><span class="p">.</span><span style="color: #004012">r</span> <span style="color: #aa2211">-</span> <span style="color: #004012">color</span><span class="p">.</span><span style="color: #004012">g</span><span class="p">)</span> <span style="color: #aa2211">+</span> <span style="color: #004012">d</span> <span style="color: #aa2211">*</span> <span style="color: #601200">4</span><span class="p">;</span> <span style="color: #004012">h</span> <span style="color: #aa2211">/=</span> <span style="color: #601200">6</span> <span style="color: #aa2211">*</span> <span style="color: #004012">d</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">break</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">return</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">h:</span> <span style="color: #004012">h</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">s:</span> <span style="color: #004012">s</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">v:</span> <span style="color: #004012">v</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="p">};</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">function</span> <span class="bright"></span><span style="color: #004012"><span class="bright">isLightColor</span></span><span class="p">(</span><span style="color: #004012">color</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">return</span></span> <span style="color: #304a96">Math</span><span class="p">.</span><span style="color: #004012">max</span><span class="p">(</span><span style="color: #004012">color</span><span class="p">.</span><span style="color: #004012">r</span><span class="p">,</span> <span style="color: #004012">color</span><span class="p">.</span><span style="color: #004012">g</span><span class="p">,</span> <span style="color: #004012">color</span><span class="p">.</span><span style="color: #004012">b</span><span class="p">)<span class="bright"></span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">></span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">0.5</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">the method lattes is using 0.2126*r + 0.7152*g + 0.0722*b is more correct<br />
(a simple one would be convertin to gray scale with qGray, but unfortunately is C++ only)</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D11262">https://phabricator.kde.org/D11262</a></div></div><br /><div><strong>To: </strong>Pitel, mart, Plasma<br /><strong>Cc: </strong>ngraham, abetts, broulik, mvourlakos, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart<br /></div>