<table><tr><td style="">romangg added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D1230">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D1230#inline-55030">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main_wayland.cpp:780</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">pluginName</span> <span style="color: #aa2211">=</span> <span class="n">KWin</span><span style="color: #aa2211">::</span><span class="n">automaticBackendSelection</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">std</span><span style="color: #aa2211">::</span><span class="n">cerr</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"Selected backend "</span> <span style="color: #aa2211"><<</span> <span class="n">pluginName</span><span class="p">.</span><span class="n">toStdString</span><span class="p">()</span> <span style="color: #aa2211"><<</span> <span class="n">std</span><span style="color: #aa2211">::</span><span class="n">endl</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Put this after the if clause (such that it shows the selected backend also on manual setting). But it's unrelated to GBM remote accesss, so better remove it and commit it as separate patch.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D1230#inline-55031">View Inline</a><span style="color: #4b4d51; font-weight: bold;">drm_backend.cpp:103</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">qCInfo</span><span class="p">(</span><span class="n">KWIN_DRM</span><span class="p">)</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"Initializing DRM backend"</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">LogindIntegration</span> <span style="color: #aa2211">*</span><span class="n">logind</span> <span style="color: #aa2211">=</span> <span class="n">LogindIntegration</span><span style="color: #aa2211">::</span><span class="n">self</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Unrelated to GBM remote access. Remove.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D1230#inline-55033">View Inline</a><span style="color: #4b4d51; font-weight: bold;">drm_output.h:139</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #a0a000">private</span><span class="p">:</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">friend</span> <span class="n">class</span> <span class="n">RemoteAccessManager</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">friend</span> <span class="n">class</span> <span class="n">DrmBackend</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Is it only a friend class to access <tt style="background: #ebebeb; font-size: 13px;">m_waylandOutput.data()</tt>? In this case better create a getter for it in DrmOutput.</p>
<p style="padding: 0; margin: 8px;">Or better do the <tt style="background: #ebebeb; font-size: 13px;">passBuffer</tt> call in <tt style="background: #ebebeb; font-size: 13px;">DrmBackend::present</tt> and give instead of the DrmOutput the <tt style="background: #ebebeb; font-size: 13px;">KWayland::Server::OutputInterface</tt> from there to <tt style="background: #ebebeb; font-size: 13px;">passBuffer</tt>.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D1230#inline-55028">View Inline</a><span style="color: #4b4d51; font-weight: bold;">egl_gbm_backend.cpp:160</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">qEnvironmentVariableIsSet</span><span class="p">(</span><span style="color: #766510">"KWIN_REMOTE"</span><span class="p">))</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">return</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Should be the default not directly activated remote funcitonality? And if one wants to deactivate remote set <tt style="background: #ebebeb; font-size: 13px;">KWIN_NO_REMOTE</tt> or something.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D1230#inline-55034">View Inline</a><span style="color: #4b4d51; font-weight: bold;">remoteaccess_manager.cpp:85</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">qCDebug</span><span class="p">(</span><span class="n">KWIN_DRM</span><span class="p">)</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"Buffer passed: bo"</span> <span style="color: #aa2211"><<</span> <span class="n">gbmbuf</span><span style="color: #aa2211">-></span><span class="n">getBo</span><span class="p">()</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">", fd"</span> <span style="color: #aa2211"><<</span> <span class="n">buf</span><span style="color: #aa2211">-></span><span class="n">fd</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This will spam the debug because it is called on every present.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>BRANCH</strong><div><div>gbm-vnc</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D1230">https://phabricator.kde.org/D1230</a></div></div><br /><div><strong>To: </strong>Kanedias, graesslin, davidedmundson, romangg, KWin<br /><strong>Cc: </strong>jgrulich, romangg, ngraham, alexeymin, aacid, kwin, KWin, davidedmundson, plasma-devel, schernikov, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein<br /></div>