<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p style="margin-top:0;margin-bottom:0">Hello there,</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0">plasma-desktop-5.12.3/kcms/hardware/joystick/joydevice.cpp:188]: (error) Memory leak: oldCorr<br>
</p>
<p style="margin-top:0;margin-bottom:0"></p>
<div><br>
Source code is<br>
<br>
<div> if ( ::ioctl(fd, JSIOCGCORR, oldCorr) == -1 )<br>
{<br>
::close(fd);<br>
delete [] oldCorr;<br>
return JoyDevice::ERR_GET_CORR;<br>
}<br>
<br>
if (bt < 0) {<br>
return JoyDevice::ERR_GET_BUTTONS;<br>
}<br>
<br>
</div>
One if statement tidies things up, the other doesn't. Suggest code rework.<br>
It would also be more efficient if the sanity check for bt were moved<br>
to just after where it is set up.<br>
<br>
Regards<br>
<br>
David Binderman<br>
<br>
</div>
<br>
<p></p>
</div>
</body>
</html>