<table><tr><td style="">xuetianweng added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D11061">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D11061#inline-53623">View Inline</a><span style="color: #4b4d51; font-weight: bold;">panel.cpp:1031</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">impanel</span><span style="color: #aa2211">-></span><span class="n">xkbLayoutManager</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">XkbLayoutManager</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">impanel</span><span style="color: #aa2211">-></span><span class="n">settings_general</span> <span style="color: #aa2211">=</span> <span class="n">g_settings_new</span> <span class="p">(</span><span class="n">IBUS_SCHEMA_GENERAL</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">impanel</span><span style="color: #aa2211">-></span><span class="n">settings_hotkey</span> <span style="color: #aa2211">=</span> <span class="n">g_settings_new</span> <span class="p">(</span><span class="n">IBUS_SCHEMA_HOTKEY</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">IMHO you need to g_object_unref this two new settings in ibus_panel_impanel_destroy.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D11061#inline-53624">View Inline</a><span style="color: #4b4d51; font-weight: bold;">panel.cpp:1033</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">impanel</span><span style="color: #aa2211">-></span><span class="n">settings_hotkey</span> <span style="color: #aa2211">=</span> <span class="n">g_settings_new</span> <span class="p">(</span><span class="n">IBUS_SCHEMA_HOTKEY</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">g_signal_connect</span><span class="p">(</span><span class="n">impanel</span><span style="color: #aa2211">-></span><span class="n">settings_general</span><span class="p">,</span> <span style="color: #766510">"changed"</span><span class="p">,</span> <span class="n">G_CALLBACK</span> <span class="p">(</span><span class="n">impanel_settings_changed_callback</span><span class="p">),</span> <span class="n">impanel</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">g_signal_connect</span><span class="p">(</span><span class="n">impanel</span><span style="color: #aa2211">-></span><span class="n">settings_hotkey</span><span class="p">,</span> <span style="color: #766510">"changed"</span><span class="p">,</span> <span class="n">G_CALLBACK</span> <span class="p">(</span><span class="n">impanel_settings_changed_callback</span><span class="p">),</span> <span class="n">impanel</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">and disconnect the signal too.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D11061">https://phabricator.kde.org/D11061</a></div></div><br /><div><strong>To: </strong>fujiwara, Plasma, hein, xuetianweng<br /><strong>Cc: </strong>plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>