<table><tr><td style="">davidedmundson requested changes to this revision.<br />davidedmundson added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D11064">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D11064#inline-53606">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.qml:187</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                        <span style="color: #aa4000">transform:</span> <span style="color: #004012">Scale</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                            <span style="color: #aa4000">xScale:</span> <span style="color: #601200">1</span><span class="p">.</span> <span style="color: #aa2211">/</span> <span style="color: #004012">QtWindow</span><span class="p">.</span><span style="color: #004012">Screen</span><span class="p">.</span><span style="color: #004012">devicePixelRatio</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                            <span style="color: #aa4000">yScale:</span> <span style="color: #601200">1</span><span class="p">.</span> <span style="color: #aa2211">/</span> <span style="color: #004012">QtWindow</span><span class="p">.</span><span style="color: #004012">Screen</span><span class="p">.</span><span style="color: #004012">devicePixelRatio</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">We dont' need these transforms.<br />
There shouldn't be any high DPI specicfic code in QML.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D11064#inline-53607">View Inline</a><span style="color: #4b4d51; font-weight: bold;">previewrenderengine.cpp:136</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">return</span> <span style="color: #004012">draw</span><span class="p">(</span><span class="n">name</span><span class="p">,</span> <span class="n">style</span><span class="p">,</span> <span class="n">faceNo</span><span class="p">,</span> <span class="n">txt</span><span class="p">,</span> <span class="n">bgnd</span><span class="p">,</span> <span class="n">fSize</span><span class="p">,</span> <span class="n">text</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">change to</p>

<p style="padding: 0; margin: 8px;">QImage image(draw(name, style,...));<br />
image.setDevicePixelRatio(ratio);<br />
return image;</p>

<p style="padding: 0; margin: 8px;">This keeps the metadata of the image scaling with the image, and then the Image item knows automatically what the logical of this image is.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D11064">https://phabricator.kde.org/D11064</a></div></div><br /><div><strong>To: </strong>progwolff, Plasma, harmathy, mart, davidedmundson<br /><strong>Cc: </strong>davidedmundson, abetts, broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart<br /></div>