<table><tr><td style="">zzag created this revision.<br />zzag added reviewers: Breeze, VDG.<br />Restricted Application added a project: Plasma.<br />Restricted Application added a subscriber: plasma-devel.<br />zzag requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D11069">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>5.12 release introduced new decoration shadows. These new shadows are<br />
bigger, centered, and they try to solve a problem related to depth.<br />
Yet, there are still some problems:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">new(5.12) shadows are hard.</li>
<li class="remarkup-list-item">lighting model is broken. Because 5.12 shadows have been centered and made bigger, they should be casted from north.</li>
</ul>
<p>This change refines how decoration shadows look:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">shadows are casted from north(shadow under window is bigger and darker, side shadows are smaller, etc);</li>
<li class="remarkup-list-item">shadows are made up of several separate shadows(one for overall shape, another for contrast). The separate shadows are produced by using box shadow helper(something similar to CSS box-shadow property, except there are no inset and spread properties);</li>
<li class="remarkup-list-item">shadow sizes(e.g. Small, Medium, and so on) haven't changed.</li>
</ul>
<p>Because GPUs can't be used for blurring images(in our case), the box shadow<br />
helper is using CPU to blur images. More precisely, when blur radius is < 64,<br />
images are blurred with "separable convolutions", otherwise, images are blurred<br />
with a two-dimensional Fourier Transform.</p>
<p>Depends on <a href="https://phabricator.kde.org/D10942" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D10942</a><br />
Depends on <a href="https://phabricator.kde.org/D10811" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D10811</a></p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R31 Breeze</div></div></div><br /><div><strong>BRANCH</strong><div><div>shadows</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D11069">https://phabricator.kde.org/D11069</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>cmake/FindFFTW.cmake<br />
kdecoration/CMakeLists.txt<br />
kdecoration/breezeboxshadowhelper.cpp<br />
kdecoration/breezeboxshadowhelper.h<br />
kdecoration/breezedecoration.cpp<br />
kdecoration/breezedecoration.h</div></div></div><br /><div><strong>To: </strong>zzag, Breeze, VDG<br /><strong>Cc: </strong>plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>