<table><tr><td style="">ngraham added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10475" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Generally looks good. A few UI comments:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">Let's use a hamburger icon as the default icon, rather than the three-dot icon. That's used elsewhere on the list to expose hidden actions; here, it's opening a standard drop-down menu, so let's use the more standard icon for it.</li>
<li class="remarkup-list-item">The button doesn't have enough right padding: <a href="https://phabricator.kde.org/F5737034" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">F5737034: Not enough padding.png</a></li>
<li class="remarkup-list-item">I'm not really satisfied with the presentation when the button has text, as seen above; there's no icon, and no downward-pointing arrow to indicate that clicking the button will open a drop-down menu.</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R169 Kirigami</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10475" rel="noreferrer">https://phabricator.kde.org/D10475</a></div></div><br /><div><strong>To: </strong>apol, Kirigami, mart, ngraham, abetts<br /><strong>Cc: </strong>rkflx, mart, ngraham, plasma-devel, apol, davidedmundson, hein<br /></div>