<table><tr><td style="">broulik created this revision.<br />broulik added reviewers: Plasma, hein.<br />Restricted Application added a project: Plasma.<br />Restricted Application added a subscriber: plasma-devel.<br />broulik requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10915" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>In <a href="https://phabricator.kde.org/R119:0d6792c4a7fc412f4710046fd90073e55194fef9" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">0d6792c</a> I turned the JS into a singleton but overlooked that it also accesses <tt style="background: #ebebeb; font-size: 13px;">plasmoid</tt> context property.<br />
Instead of randomly calling outside objects from this library function, signal what the caller should do.<br />
The function already returned <tt style="background: #ebebeb; font-size: 13px;">undefined</tt> for doing nothing, and <tt style="background: #ebebeb; font-size: 13px;">true</tt> for requesting a close. Changed all call sites of this function to explicitly check for <tt style="background: #ebebeb; font-size: 13px;">true</tt></p></div></div><br /><div><strong>TEST PLAN</strong><div><ul class="remarkup-list">
<li class="remarkup-list-item">Adding app to desktop from Kickoff closed menu</li>
<li class="remarkup-list-item">Adding app to desktop from Kicker closed menu</li>
<li class="remarkup-list-item">Adding app to desktop from dashboard closed dashboard</li>
<li class="remarkup-list-item">Adding an item to favorites did not close the menu</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10915" rel="noreferrer">https://phabricator.kde.org/D10915</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>applets/kicker/package/contents/code/tools.js<br />
applets/kicker/package/contents/ui/DashboardRepresentation.qml<br />
applets/kicker/package/contents/ui/ItemGridDelegate.qml<br />
applets/kicker/package/contents/ui/ItemListDelegate.qml<br />
applets/kicker/package/contents/ui/SideBarItem.qml<br />
applets/kickoff/package/contents/code/tools.js<br />
applets/kickoff/package/contents/ui/KickoffItem.qml</div></div></div><br /><div><strong>To: </strong>broulik, Plasma, hein<br /><strong>Cc: </strong>plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>