<table><tr><td style="">kossebau added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10793" rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D10793#212670" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D10793#212670</a>, <a href="https://phabricator.kde.org/p/davidedmundson/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@davidedmundson</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Changing i18n in stable as a bug fix is allowed, but CC kde-i18n-doc.</p></div>
</blockquote>
<p>Given I just copied the same string as used for the metadata of the internal grouping package and all desktop files being merged into one catalog per module, translators should not be really effected here though, as it will just mean the same string with same context used in another place :)<br />
Cmp. <a href="https://websvn.kde.org/branches/stable/l10n-kf5/templates/messages/kde-workspace/desktop_workspace_kdeplasma-addons.pot?view=markup" class="remarkup-link" target="_blank" rel="noreferrer">https://websvn.kde.org/branches/stable/l10n-kf5/templates/messages/kde-workspace/desktop_workspace_kdeplasma-addons.pot?view=markup</a></p>
<p>So would not grep their attention for this one.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Has there been already a request for a custom icon be filed</p></blockquote>
<p>Don't think so</p></blockquote>
<p>K, Will file one.</p>
<p>Thanks for review</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R114 Plasma Addons</div></div></div><br /><div><strong>BRANCH</strong><div><div>fixgroupingmissingcomment</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10793" rel="noreferrer">https://phabricator.kde.org/D10793</a></div></div><br /><div><strong>To: </strong>kossebau, davidedmundson<br /><strong>Cc: </strong>plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>