<table><tr><td style="">kossebau added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10499" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Thanks for review.</p>
<blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D10499#210493" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D10499#210493</a>, <a href="https://phabricator.kde.org/p/broulik/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@broulik</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">and then copy the correct or suggested into the clipboard for further usage?</pre></div></blockquote>
<p>Calculator runner does <tt style="background: #ebebeb; font-size: 13px;">setText</tt> on <tt style="background: #ebebeb; font-size: 13px;">QClipboard</tt> in <tt style="background: #ebebeb; font-size: 13px;">run</tt>, so I guess this is the way.</p></div>
</blockquote>
<p>Which seems to not be triggered when chosing the match though, from what I tested incl. extra debug log.</p>
<p>Currently one has to use the action enabled on the match to get the result copied to the clipboard.</p>
<p>So chance is that code is dead code, either due to being copy&paste on plugin creation or due to policy changes in krunner plasma5 porting?</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p><tt style="background: #ebebeb; font-size: 13px;">InformationalMatch</tt> causes the <tt style="background: #ebebeb; font-size: 13px;">data</tt> to be set as query when run. Pick your poison.</p></blockquote>
<p>I guess that most use cases with this runner are when someone wants to use to correct term in other places, so on selecting the match people do not intend to have it as new query content for further queries, but have the term straight available for use in that other place (-> clipboard).<br />
So considering to take the HelperMatch pill. Though might also go for extra copy action as with calculator.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R114 Plasma Addons</div></div></div><br /><div><strong>BRANCH</strong><div><div>spellrunnerMakeTermsCopyable</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10499" rel="noreferrer">https://phabricator.kde.org/D10499</a></div></div><br /><div><strong>To: </strong>kossebau, broulik<br /><strong>Cc: </strong>plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>