<table><tr><td style="">broulik added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10512" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10512#inline-50670" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">appletquickitem.cpp:55</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">qEnvironmentVariableIsSet</span><span class="p">(</span><span style="color: #766510">"KDE_PLASMA_PRELOAD_POLICY"</span><span class="p">))</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span class="n">QByteArray</span> <span class="n">policy</span> <span style="color: #aa2211">=</span> <span class="n">qgetenv</span><span class="p">(</span><span style="color: #766510">"KDE_PLASMA_PRELOAD_POLICY"</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Cache the result in a static to read it only once?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10512#inline-50672" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">appletquickitem.cpp:57</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span class="n">QByteArray</span> <span class="n">policy</span> <span style="color: #aa2211">=</span> <span class="n">qgetenv</span><span class="p">(</span><span style="color: #766510">"KDE_PLASMA_PRELOAD_POLICY"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">policy</span> <span style="color: #aa2211">==</span> <span style="color: #766510">"Aggressive"</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">preloadPolicy</span> <span style="color: #aa2211">=</span> <span class="n">Aggressive</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">case insensitive?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10512#inline-50673" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">appletquickitem.cpp:653</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span style="color: #aa4000">int</span> <span class="n">delay</span> <span style="color: #aa2211">=</span> <span class="n">qrand</span><span class="p">()</span> <span style="color: #aa2211">%</span> <span class="p">((</span><span class="n">max</span> <span style="color: #aa2211">+</span> <span style="color: #601200">1</span><span class="p">)</span> <span style="color: #aa2211">-</span> <span class="n">min</span><span class="p">)</span> <span style="color: #aa2211">+</span> <span class="n">min</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QTimer</span><span style="color: #aa2211">::</span><span class="n">singleShot</span><span class="p">(</span><span class="n">delay</span><span class="p">,</span> <span class="p">[</span><span style="color: #aa4000">this</span><span class="p">,</span> <span class="n">delay</span><span class="p">]()</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">qCInfo</span><span class="p">(</span><span class="n">LOG_PLASMAQUICK</span><span class="p">)</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"Delayed preload of "</span> <span style="color: #aa2211"><<</span> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">applet</span><span style="color: #aa2211">-></span><span class="n">title</span><span class="p">()</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"after"</span> <span style="color: #aa2211"><<</span> <span class="p">(</span><span class="n">qreal</span><span class="p">)</span><span class="n">delay</span><span style="color: #aa2211">/</span><span style="color: #601200">1000</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"seconds"</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Still missing <tt style="background: #ebebeb; font-size: 13px;">this</tt> context:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">QTimer::singleShot(delay, this, [this, delay]() {</pre></div></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework (Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10512" rel="noreferrer">https://phabricator.kde.org/D10512</a></div></div><br /><div><strong>To: </strong>mart, Plasma<br /><strong>Cc: </strong>davidedmundson, broulik, apol, ngraham, plasma-devel, Frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart<br /></div>