<table><tr><td style="">davidedmundson created this revision.<br />davidedmundson added a reviewer: Plasma.<br />Restricted Application added a project: Plasma.<br />Restricted Application added a subscriber: plasma-devel.<br />davidedmundson requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10668" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>5.11 -> 5.12 migrated shortcuts from kded5 to the correct component name<br />
org_kde_powerdevil for good reasons<br />
However, despite a kconfupdate script working correctly and moving the<br />
old keys, kglobalaccel is running whilst we update and it syncs the old<br />
values later. On future loads it detects the duplication and removes the<br />
powerdevil entries.</p>
<p>This patch removes the old powermanagent entries in the kded5 component<br />
at powerdevil startup which is at runtime where we can talk to<br />
kglobalaccel, but before powerdevil has registered the new actions.</p>
<p>This should handle both users that haven't upgraded to 5.12 yet, as well<br />
as users who hit the previous config script.</p>
<p>Ideally kconf_update needs to be patched to do migration at appropriate<br />
times.</p>
<p>BUG: 389991<br />
FIXED-IN: 5.12.2</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>"broke" my config by putting in values in the old place with a custom shortcut for poweroff<br />
Restarted kglobalaccel<br />
Ran powerdevil<br />
Shortucts worked<br />
Cleanly quit kglobalaccel<br />
Config stayed synced</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R122 Powerdevil</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10668" rel="noreferrer">https://phabricator.kde.org/D10668</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>CMakeLists.txt<br />
daemon/powerdevilapp.cpp<br />
daemon/powerdevilapp.h<br />
kconf_update/CMakeLists.txt<br />
kconf_update/powerdevil_move_shortcuts.upd</div></div></div><br /><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: </strong>plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>