<table><tr><td style="">michaelh created this revision.<br />michaelh added reviewers: Plasma, Plasma: Workspaces.<br />Restricted Application added a project: Plasma.<br />Restricted Application added a subscriber: plasma-devel.<br />michaelh requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10623" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>This diff is purely informational.</p>

<p>Without this patch compilation of plasma-workspace fails with:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">    ~/bin/kde-latest/include/ksysguard/processcore/processes.h:61:54: error: ‘null’ is not a member of ‘QString’
             Processes(const QString &hostname = QString::null, QObject * parent = nullptr);
                                                          ^~~~
    make[2]: *** [systemmonitor/CMakeFiles/systemmonitor.dir/build.make:63: systemmonitor/CMakeFiles/systemmonitor.dir/ksystemactivitydialog.cpp.o] Error 1
    make[1]: *** [CMakeFiles/Makefile2:3206: systemmonitor/CMakeFiles/systemmonitor.dir/all] Error 2
    make: *** [Makefile:130: all] Error 2
    *** Failure: Exit code 2 **
```*

Maybe this is a real fix, may not.
BTW, I'm very curious to know why libksysguard and ksysguard compile without this patch, while plasma-workspace does not.</pre></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R111 KSysguard Library</div></div></div><br /><div><strong>BRANCH</strong><div><div>plasma (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10623" rel="noreferrer">https://phabricator.kde.org/D10623</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>processcore/processes.h</div></div></div><br /><div><strong>To: </strong>michaelh, Plasma, Plasma: Workspaces<br /><strong>Cc: </strong>plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>