<table><tr><td style="">michaelh added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10079" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10079#inline-50233" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">baloosearchrunner.cpp:103</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">match<span class="bright">es</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">match</span>Internal</span><span class="p">(</span><span class="n">m_searchTerm</span><span class="p">,</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"<span class="bright">Document</span>"</span><span class="p">),</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"<span class="bright">Document</span>"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">match<span class="bright">es</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">match</span>Internal</span><span class="p">(</span><span class="n">m_searchTerm</span><span class="p">,</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"<span class="bright">Video</span>"</span><span class="p">),</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"<span class="bright">Video</span>"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span class="n"><span class="bright">matches</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">m</span>atch<span class="bright">Internal</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">m_searchTerm</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n"><span class="bright">QStringLiteral</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Folder"</span></span><span class="bright"></span><span class="p"><span class="bright">),</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Folder"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span>);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">QDBusConnection</span><span style="color: #aa2211">::</span><span class="n">sessionBus</span><span class="p">().</span><span class="n">send</span><span class="p">(</span><span class="n">m_lastRequest</span><span class="p">.</span><span class="n">createReply</span><span class="p">(</span><span class="n">QVariant</span><span style="color: #aa2211">::</span><span class="n">fromValue</span><span class="p">(</span><span class="n">matches</span><span class="p">)));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">m_lastRequest</span> <span style="color: #aa2211">=</span> <span class="n">QDBusMessage</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">matchInternal</span><span class="p">(</span><span class="n">m_searchTerm</span><span class="p">,</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"<span class="bright">Video</span>"</span><span class="p">),</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"<span class="bright">Video</span>"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">matchInternal</span><span class="p">(</span><span class="n">m_searchTerm</span><span class="p">,</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"<span class="bright">Folder</span>"</span><span class="p">),</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"<span class="bright">Folder</span>"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span class="n"><span class="bright">finishM</span>atch<span class="bright">ing</span></span><span class="bright"></span><span class="p"><span class="bright">(</span>);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Baloo can also handle these types</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">Archive</li>
<li class="remarkup-list-item">Spreadsheet (also found with type:Document)</li>
<li class="remarkup-list-item">Presentation (also found with type:Document)</li>
</ul>
<p style="padding: 0; margin: 8px;">see <a href="https://cgit.kde.org/baloo.git/tree/src/file/basicindexingjob.cpp#n119" class="remarkup-link" target="_blank" rel="noreferrer">basicindexingjob</a><br />
Currently those can only be found with e.g. <tt style="background: #ebebeb; font-size: 13px;">$ baloosearch type:Archive</tt>. <br />
Please make them available in KRunner too.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>BRANCH</strong><div><div>portBalooRunnerToKDBusRunner</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10079" rel="noreferrer">https://phabricator.kde.org/D10079</a></div></div><br /><div><strong>To: </strong>kossebau, davidedmundson, broulik, mart<br /><strong>Cc: </strong>michaelh, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>