<table><tr><td style="">rkflx added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10297" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Just tried the patch. I think for <span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">System Activity</span></span></span> / <kbd style="display: inline-block; min-width: 1em; padding: 4px 5px 5px; font-weight: normal; font-size: 0.8rem; text-align: center; text-decoration: none; line-height: 0.6rem; border-radius: 3px; box-shadow: inset 0 -1px 0 rgba(71, 87, 120, 0.08); user-select: none; background: #f7f7f7; border: 1px solid #C7CCD9;">Ctrl</kbd><span class="kbd-join" style="padding: 0 4px; color: #92969D;">+</span><kbd title="Escape" style="display: inline-block; min-width: 1em; padding: 4px 5px 5px; font-weight: normal; font-size: 0.8rem; text-align: center; text-decoration: none; line-height: 0.6rem; border-radius: 3px; box-shadow: inset 0 -1px 0 rgba(71, 87, 120, 0.08); user-select: none; background: #f7f7f7; border: 1px solid #C7CCD9;">⎋</kbd> the button is fine (annoyingly with a slightly larger height than the combobox, but that's life…). For <span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">KSysGuard</span></span></span> itself it looks a bit odd, why would it appear exactly on this tab page? I could imagine the menubar would be a better place.</p>
<p>(Sorry this comes so late, I only reviewed in more detail because nobody from Plasma bothered so far. Ignore my comment if you want.)</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R111 KSysguard Library</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10297" rel="noreferrer">https://phabricator.kde.org/D10297</a></div></div><br /><div><strong>To: </strong>gregormi, Plasma<br /><strong>Cc: </strong>anthonyfieroni, andreaska, rkflx, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>