<table><tr><td style="">jtamate edited the summary of this revision. <a href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-r2kkuct6pnk5y54/" rel="noreferrer">(Show Details)</a><br />jtamate edited the test plan for this revision. <a href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-b4xpcnuuaoqvgyj/" rel="noreferrer">(Show Details)</a>
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10342" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>CHANGES TO REVISION SUMMARY</strong><div><div style="white-space: pre-wrap; color: #74777D;"><span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">store the const iterator return</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">Store the const iterator returned, not the address, so it can be checked against constEnd().<br />
Call windowInfo instead of appData, because it is not as expensive. appData is being delet</span>ed, <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">not the address</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">calculated and stored when changing tabs in konsole or saving files in kate</span>.<div style="padding: 8px 0;">...</div>{F5695178}<span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);"><br />
<br />
Cache the calls to windowUrlFromMetadata, because it can be called quite often, for example with the vivaldi browser started, and it usually calls KServiceTypeTrader::defaultOffers that also involves I/O.</span><br />
<br />
CCBUG: 342056<div style="padding: 8px 0;">...</div></div></div></div><br /><div><strong>CHANGES TO TEST PLAN</strong><div><div style="white-space: pre-wrap; color: #74777D;">Moving 50.000 small files in dolphin with drag&drop between two disks.<span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);"><br />
Doing that with vivaldi browser started.</span></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10342" rel="noreferrer">https://phabricator.kde.org/D10342</a></div></div><br /><div><strong>To: </strong>jtamate, Plasma: Workspaces, hein<br /><strong>Cc: </strong>mwolff, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>