<table><tr><td style="">broulik created this revision.<br />broulik added reviewers: Plasma, hein.<br />Restricted Application added a project: Plasma.<br />Restricted Application added a subscriber: plasma-devel.<br />broulik requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10507" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Otherwise we would create an instance of this JS file for every delegate.<br />
The only contextual object it uses is <tt style="background: #ebebeb; font-size: 13px;">i18n</tt>, so pass that in for the function call.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Verified that the JS file is created only once. Speeds up things somewhat.<br />
Verified that the favorites action still shows properly and works</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10507" rel="noreferrer">https://phabricator.kde.org/D10507</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>applets/kicker/package/contents/code/tools.js<br />
applets/kicker/package/contents/ui/DashboardRepresentation.qml<br />
applets/kicker/package/contents/ui/ItemGridDelegate.qml<br />
applets/kicker/package/contents/ui/ItemListDelegate.qml<br />
applets/kicker/package/contents/ui/SideBarItem.qml<br />
applets/kickoff/package/contents/code/tools.js<br />
applets/kickoff/package/contents/ui/KickoffItem.qml</div></div></div><br /><div><strong>To: </strong>broulik, Plasma, hein<br /><strong>Cc: </strong>plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>