<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10487" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>The part I care about is deciding what the problem is, and understanding the code around it.</p>
<p>The goal apparently was to match the application icon on the left, which means any patch needs to be able to describe the current padding that happens there, and the current padding that happens here.</p>
<p>Without that anything is guesswork.</p>
<p>This patch adds padding directly through resizing (but only in one of the two paths of the size if statement) and then there's a completely separate additional path with the marginHints in tasksRow going through to AbstractItem doing the same thing, but differently.</p>
<p>I'm fine with changing it, but not blindly.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10487" rel="noreferrer">https://phabricator.kde.org/D10487</a></div></div><br /><div><strong>To: </strong>pgkos, Plasma: Workspaces, davidedmundson<br /><strong>Cc: </strong>ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>