<table><tr><td style="">zzag added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10480" rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>this is because you have to rely on maxIconWidth, even if the current item has no icon, when computing the checkbox space.</p></blockquote>

<p>I've came up with something like this</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="cpp" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: #aa4000">if</span><span class="p">(</span> <span class="n">showIcon</span> <span style="color: #aa2211">&&</span> <span class="n">menuItemOption</span><span style="color: #aa2211">-></span><span class="n">maxIconWidth</span> <span style="color: #aa2211">></span> <span style="color: #601200">0</span> <span class="p">)</span>
<span class="p">{</span>
    <span style="color: #aa4000">int</span> <span class="n">dx</span> <span style="color: #aa2211">=</span> <span class="p">(</span><span class="n">iconRect</span><span class="p">.</span><span class="n">left</span><span class="p">()</span> <span style="color: #aa2211">-</span> <span class="n">Metrics</span><span style="color: #aa2211">::</span><span class="n">CheckBox_Size</span><span class="p">)</span> <span style="color: #aa2211">/</span> <span style="color: #601200">2</span><span class="p">;</span>
    <span class="n">checkBoxRect</span><span class="p">.</span><span class="n">moveLeft</span><span class="p">(</span> <span class="n">dx</span> <span class="p">);</span>
<span class="p">}</span> <span style="color: #aa4000">else</span> <span class="p">{</span>
    <span style="color: #aa4000">int</span> <span class="n">dx</span> <span style="color: #aa2211">=</span> <span class="p">(</span><span class="n">textRect</span><span class="p">.</span><span class="n">left</span><span class="p">()</span> <span style="color: #aa2211">-</span> <span class="n">Metrics</span><span style="color: #aa2211">::</span><span class="n">CheckBox_Size</span><span class="p">)</span> <span style="color: #aa2211">/</span> <span style="color: #601200">2</span><span class="p">;</span>
    <span class="n">checkBoxRect</span><span class="p">.</span><span class="n">moveLeft</span><span class="p">(</span> <span class="n">dx</span> <span class="p">);</span>
<span class="p">}</span></pre></div>

<p>so, it centers properly checkboxes in menu items with and without icons</p>

<p><a href="https://phabricator.kde.org/F5709869" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">F5709869: f.png</a></p>

<p><a href="https://phabricator.kde.org/F5709874" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">F5709874: g.png</a></p>

<p><em>(it can be simplified with a ternary operator)</em></p>

<p>is it a good approach?</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R31 Breeze</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10480" rel="noreferrer">https://phabricator.kde.org/D10480</a></div></div><br /><div><strong>To: </strong>zzag, Breeze, VDG, hpereiradacosta<br /><strong>Cc: </strong>plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>