<table><tr><td style="">ngraham added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10297" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Looks awesome, +1 from me feature-wise. Just a few a naive code comments for now.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10297#inline-48571" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ksysguardprocesslist.cpp:360</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #74777d">//Sort by username by default</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Let's do unrelated whitespace/style cleanup in another patch.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10297#inline-48570" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ksysguardprocesslist.cpp:486</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">mUi</span><span style="color: #aa2211">-></span><span class="n">btnKillProcess</span><span style="color: #aa2211">-></span><span class="n">setEnabled</span><span class="p">(<span class="bright"></span></span><span class="bright"> </span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">mUi</span><span style="color: #aa2211">-></span><span class="n">treeView</span><span style="color: #aa2211">-></span><span class="n">selectionModel</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">hasSelection</span><span class="p">()<span class="bright"></span></span><span class="bright"> </span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">mUi</span><span style="color: #aa2211">-></span><span class="n">treeView</span><span style="color: #aa2211">-></span><span class="n">scrollTo</span><span class="p">(<span class="bright"></span></span><span class="bright"> </span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">mUi</span><span style="color: #aa2211">-></span><span class="n">treeView</span><span style="color: #aa2211">-></span><span class="n">currentIndex</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">mUi</span><span style="color: #aa2211">-></span><span class="n">btnKillProcess</span><span style="color: #aa2211">-></span><span class="n">setEnabled</span><span class="p">(</span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">mUi</span><span style="color: #aa2211">-></span><span class="n">treeView</span><span style="color: #aa2211">-></span><span class="n">selectionModel</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">hasSelection</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">mUi</span><span style="color: #aa2211">-></span><span class="n">treeView</span><span style="color: #aa2211">-></span><span class="n">scrollTo</span><span class="p">(</span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">mUi</span><span style="color: #aa2211">-></span><span class="n">treeView</span><span style="color: #aa2211">-></span><span class="n">currentIndex</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Let's do unrelated whitespace/style cleanup in another patch.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10297#inline-48569" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ksysguardprocesslist.cpp:525</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">mNumItemsSelected</span> <span style="color: #aa2211">=</span> <span class="n">numSelected</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">mUi</span><span style="color: #aa2211">-></span><span class="n">btnKillProcess</span><span style="color: #aa2211">-></span><span class="n">setEnabled</span><span class="p">(<span class="bright"></span></span><span class="bright"> </span><span class="n">numSelected</span> <span style="color: #aa2211">!=</span> <span style="color: #601200">0<span class="bright"></span></span><span class="bright"> </span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">mUi</span><span style="color: #aa2211">-></span><span class="n">btnKillProcess</span><span style="color: #aa2211">-></span><span class="n">setEnabled</span><span class="p">(</span><span class="n">numSelected</span> <span style="color: #aa2211">!=</span> <span style="color: #601200">0</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Let's do unrelated whitespace/style cleanup in another patch.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R111 KSysguard Library</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10297" rel="noreferrer">https://phabricator.kde.org/D10297</a></div></div><br /><div><strong>To: </strong>gregormi, Plasma<br /><strong>Cc: </strong>rkflx, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>