<table><tr><td style="">broulik added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10342" rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>every time I changed konsole tabs, saved a file in kate, the appDataFromUrl (missed the cache) was called.</p></blockquote>

<p>Whenever <tt style="background: #ebebeb; font-size: 13px;">NET::WMVisibleName </tt> changes, both caches are evicted. It might be worth checking what's more expensive to create, the <tt style="background: #ebebeb; font-size: 13px;">KWindowInfo</tt> or <tt style="background: #ebebeb; font-size: 13px;">AppData</tt> and then use one or the other depending on it, e.g. use the <tt style="background: #ebebeb; font-size: 13px;">KWindowInfo</tt> for the <tt style="background: #ebebeb; font-size: 13px;">visibleName</tt> and don't nuke the <tt style="background: #ebebeb; font-size: 13px;">appDataCache</tt> when that changes, or so. I'm not very familiar with that codebase.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10342#inline-48296" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xwindowtasksmodel.cpp:330</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">wipeInfoCache</span> <span style="color: #aa2211">=</span> <span style="color: #304a96">true</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">wipeAppDataCache</span> <span style="color: #aa2211">=</span> <span style="color: #304a96">true</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">changedRoles</span> <span style="color: #aa2211"><<</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">DisplayRole</span> <span style="color: #aa2211"><<</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">DecorationRole</span> <span style="color: #aa2211"><<</span> <span class="n">AppId</span> <span style="color: #aa2211"><<</span> <span class="n">AppName</span> <span style="color: #aa2211"><<</span> <span class="n">GenericName</span> <span style="color: #aa2211"><<</span> <span class="n">LauncherUrl</span> <span style="color: #aa2211"><<</span> <span class="n">AppPid</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">However, just *not* killing the cache would lead to <tt style="background: #ebebeb; font-size: 13px;">DisplayRole</tt>, <tt style="background: #ebebeb; font-size: 13px;">AppId</tt>, <tt style="background: #ebebeb; font-size: 13px;">AppName</tt>, <tt style="background: #ebebeb; font-size: 13px;">GenericName</tt> not updating as these are taken from <tt style="background: #ebebeb; font-size: 13px;">appData</tt> in <tt style="background: #ebebeb; font-size: 13px;">data()</tt></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10342" rel="noreferrer">https://phabricator.kde.org/D10342</a></div></div><br /><div><strong>To: </strong>jtamate, Plasma: Workspaces<br /><strong>Cc: </strong>broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>