<table><tr><td style="">broulik accepted this revision.<br />broulik added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10223" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Please remove the unrelated changes before pushing</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10223#inline-47963" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">foldermodel.cpp:1896-1900</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">m_appletInterface</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">Plasma</span><span style="color: #aa2211">::</span><span class="n">Applet</span> <span style="color: #aa2211">*</span><span class="n">applet</span> <span style="color: #aa2211">=</span> <span class="n">m_appletInterface</span><span style="color: #aa2211">-></span><span class="n">property</span><span class="p">(</span><span style="color: #766510">"_plasma_applet"</span><span class="p">).</span><span class="n">value</span><span style="color: #aa2211"><</span><span class="n">Plasma</span><span style="color: #aa2211">::</span><span class="n">Applet</span> <span style="color: #aa2211">*></span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">QQuickItem</span><span style="color: #aa2211">*</span> <span class="n">gObj</span> <span style="color: #aa2211">=</span> <span class="n">qobject_cast</span><span style="color: #aa2211"><</span><span class="n">QQuickItem</span> <span style="color: #aa2211">*></span><span class="p">(</span><span class="n">applet</span><span style="color: #aa2211">-></span><span class="n">property</span><span class="p">(</span><span style="color: #766510">"_plasma_graphicObject"</span><span class="p">).</span><span class="n">value</span><span style="color: #aa2211"><</span><span class="n">QObject</span> <span style="color: #aa2211">*></span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">uiDelegate</span><span class="p">.</span><span class="n">setQWindow</span><span class="p">(</span><span class="n">gObj</span><span style="color: #aa2211">-></span><span class="n">window</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Unrelated?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10223#inline-47964" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">foldermodel.cpp:1918-1922</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">m_appletInterface</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">Plasma</span><span style="color: #aa2211">::</span><span class="n">Applet</span> <span style="color: #aa2211">*</span><span class="n">applet</span> <span style="color: #aa2211">=</span> <span class="n">m_appletInterface</span><span style="color: #aa2211">-></span><span class="n">property</span><span class="p">(</span><span style="color: #766510">"_plasma_applet"</span><span class="p">).</span><span class="n">value</span><span style="color: #aa2211"><</span><span class="n">Plasma</span><span style="color: #aa2211">::</span><span class="n">Applet</span> <span style="color: #aa2211">*></span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">QQuickItem</span><span style="color: #aa2211">*</span> <span class="n">gObj</span> <span style="color: #aa2211">=</span> <span class="n">qobject_cast</span><span style="color: #aa2211"><</span><span class="n">QQuickItem</span> <span style="color: #aa2211">*></span><span class="p">(</span><span class="n">applet</span><span style="color: #aa2211">-></span><span class="n">property</span><span class="p">(</span><span style="color: #766510">"_plasma_graphicObject"</span><span class="p">).</span><span class="n">value</span><span style="color: #aa2211"><</span><span class="n">QObject</span> <span style="color: #aa2211">*></span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">uiDelegate</span><span class="p">.</span><span class="n">setQWindow</span><span class="p">(</span><span class="n">gObj</span><span style="color: #aa2211">-></span><span class="n">window</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Unrelated?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10223#inline-47965" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">foldermodel.cpp:1956-1960</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">m_appletInterface</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">Plasma</span><span style="color: #aa2211">::</span><span class="n">Applet</span> <span style="color: #aa2211">*</span><span class="n">applet</span> <span style="color: #aa2211">=</span> <span class="n">m_appletInterface</span><span style="color: #aa2211">-></span><span class="n">property</span><span class="p">(</span><span style="color: #766510">"_plasma_applet"</span><span class="p">).</span><span class="n">value</span><span style="color: #aa2211"><</span><span class="n">Plasma</span><span style="color: #aa2211">::</span><span class="n">Applet</span> <span style="color: #aa2211">*></span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">QQuickItem</span><span style="color: #aa2211">*</span> <span class="n">gObj</span> <span style="color: #aa2211">=</span> <span class="n">qobject_cast</span><span style="color: #aa2211"><</span><span class="n">QQuickItem</span> <span style="color: #aa2211">*></span><span class="p">(</span><span class="n">applet</span><span style="color: #aa2211">-></span><span class="n">property</span><span class="p">(</span><span style="color: #766510">"_plasma_graphicObject"</span><span class="p">).</span><span class="n">value</span><span style="color: #aa2211"><</span><span class="n">QObject</span> <span style="color: #aa2211">*></span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">uiDelegate</span><span class="p">.</span><span class="n">setQWindow</span><span class="p">(</span><span class="n">gObj</span><span style="color: #aa2211">-></span><span class="n">window</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Unrelated?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>BRANCH</strong><div><div>Plasma/5.12</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10223" rel="noreferrer">https://phabricator.kde.org/D10223</a></div></div><br /><div><strong>To: </strong>hein, Plasma, broulik<br /><strong>Cc: </strong>broulik, ngraham, kossebau, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>