<table><tr><td style="">Zren created this revision.<br />Zren added a reviewer: Plasma.<br />Restricted Application added a project: Plasma.<br />Restricted Application added a subscriber: plasma-devel.<br />Zren requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10219" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Based on <a href="https://phabricator.kde.org/D5209" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: line-through;" rel="noreferrer">D5209</a>, which adds this feature to plasma-framework.</p>
<hr class="remarkup-hr" />
<p><a href="https://phabricator.kde.org/D5209" class="remarkup-link" target="_blank" rel="noreferrer">https://phabricator.kde.org/D5209</a></p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Assuming <tt style="background: #ebebeb; font-size: 13px;">/usr/share/locale/fr/LC_MESSAGES/plasma_applet_org.kde.plasma.digitalclock.mo</tt> exists.</p>
<ul class="remarkup-list">
<li class="remarkup-list-item"><tt style="background: #ebebeb; font-size: 13px;">LANGUAGE=fr plasmoidviewer -a org.kde.plasma.digitalclock</tt><ul class="remarkup-list">
<li class="remarkup-list-item"><tt style="background: #ebebeb; font-size: 13px;">i18n()</tt> strings are translated into french.</li>
<li class="remarkup-list-item">Qt datetime formatting (<tt style="background: #ebebeb; font-size: 13px;">Qt.formatDate(tzDate,"dddd")</tt>) like in digitalclock's tooltip <strong>uses the system locale</strong>.</li>
</ul></li>
<li class="remarkup-list-item"><tt style="background: #ebebeb; font-size: 13px;">LANG=fr_CA.UTF-8 LANGUAGE=fr plasmoidviewer -a org.kde.plasma.digitalclock</tt><ul class="remarkup-list">
<li class="remarkup-list-item"><tt style="background: #ebebeb; font-size: 13px;">i18n()</tt> strings are translated into french.</li>
<li class="remarkup-list-item">Qt datetime formatting uses the french canadian locale.</li>
</ul></li>
</ul>
<p>Before patch:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item"><tt style="background: #ebebeb; font-size: 13px;">LANGUAGE=fr plasmoidviewer -a ./package</tt><ul class="remarkup-list">
<li class="remarkup-list-item"><tt style="background: #ebebeb; font-size: 13px;">i18n()</tt> strings are <strong>not translated</strong>.</li>
</ul></li>
<li class="remarkup-list-item"><tt style="background: #ebebeb; font-size: 13px;">plasmoidviewer -a ./bundle.plasmoid</tt><ul class="remarkup-list">
<li class="remarkup-list-item">Does not work. Seems it needs to be extracted first for plasmoidviewer to work.</li>
</ul></li>
</ul>
<p>After patch:<br />
First setup a test env that doesn't have translations elsewhere.</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">cp -r /usr/share/plasma/plasmoids/org.kde.plasma.volume .
cd org.kde.plasma.volume
mkdir -p contents/locale/fr/LC_MESSAGES
rm metadata.json
kwriteconfig5 --file "$(realpath metadata.desktop)" --group "Desktop Entry" --key "X-KDE-PluginInfo-Name" "org.kde.plasma.volumetest"
cd contents/locale/fr/LC_MESSAGES
cp /usr/share/locale/fr/LC_MESSAGES/plasma_applet_org.kde.plasma.volume.mo .
mv plasma_applet_org.kde.plasma.volume.mo plasma_applet_org.kde.plasma.volumetest.mo
cd ../../../..</pre></div>
<ul class="remarkup-list">
<li class="remarkup-list-item"><tt style="background: #ebebeb; font-size: 13px;">LANGUAGE=fr plasmoidviewer -a .</tt><ul class="remarkup-list">
<li class="remarkup-list-item"><tt style="background: #ebebeb; font-size: 13px;">i18n()</tt> strings are translated into french, loaded from <tt style="background: #ebebeb; font-size: 13px;">./package/contents/locale/fr/LC_MESSAGES/plasma_applet_na.me.space.mo</tt></li>
</ul></li>
<li class="remarkup-list-item">Tested when <tt style="background: #ebebeb; font-size: 13px;">contents/locale</tt> doesn't exist.</li>
<li class="remarkup-list-item">Tested when <tt style="background: #ebebeb; font-size: 13px;">metadata.desktop</tt> and <tt style="background: #ebebeb; font-size: 13px;">metadata.json</tt> doesn't exist.</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R118 Plasma SDK</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10219" rel="noreferrer">https://phabricator.kde.org/D10219</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>plasmoidviewer/view.cpp</div></div></div><br /><div><strong>To: </strong>Zren, Plasma<br /><strong>Cc: </strong>plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>