<table><tr><td style="">ngraham updated this revision to Diff 26024.<br />ngraham added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10131" rel="noreferrer">View Revision</a></tr></table><br /><div><div><ul class="remarkup-list">
<li class="remarkup-list-item">Don't create unnecessary stub functions</li>
<li class="remarkup-list-item">Don't unnecessarily re-define variables ApplicationPage.qml</li>
<li class="remarkup-list-item">Show all the new URLs by default (when available)</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R134 Discover Software Store</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D10131?vs=26023&id=26024" rel="noreferrer">https://phabricator.kde.org/D10131?vs=26023&id=26024</a></div></div><br /><div><strong>BRANCH</strong><div><div>more-URLs</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10131" rel="noreferrer">https://phabricator.kde.org/D10131</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>discover/qml/ApplicationPage.qml<br />
libdiscover/backends/DummyBackend/DummyResource.cpp<br />
libdiscover/backends/DummyBackend/DummyResource.h<br />
libdiscover/backends/FlatpakBackend/FlatpakResource.cpp<br />
libdiscover/backends/FlatpakBackend/FlatpakResource.h<br />
libdiscover/backends/PackageKitBackend/AppPackageKitResource.cpp<br />
libdiscover/backends/PackageKitBackend/AppPackageKitResource.h<br />
libdiscover/backends/SnapBackend/SnapResource.cpp<br />
libdiscover/backends/SnapBackend/SnapResource.h<br />
libdiscover/resources/AbstractResource.cpp<br />
libdiscover/resources/AbstractResource.h</div></div></div><br /><div><strong>To: </strong>ngraham, apol, Discover Software Store<br /><strong>Cc: </strong>plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>