<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10032" rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>That might be a sign that it's unintuitive and confusing for a lot of our users. Perhaps we should reconsider.</p></blockquote>
<p>I agree there's a problem. We have the same icon meaning two different things and there's no visual clues to infer from context.</p>
<p>But I'm far from convinced by the solution.</p>
<p>Plasma volume is interesting:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">The behaviour of the system tray shows state. It shows a speaker when the speakers are on.</pre></div>
<p>(which is what we do here. This patch is the equivalent to us showing mute when the speakers are on)</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">The buttons next to the sliders to toggle mute show the current state, not the intended state</pre></div>
<p>(equivalent to us showing the play button on the popup controls when we're actively playing.. the inverse of this patch.)</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">In the KCM / settings; the mute button shows the mute icon constantly and is a toggle button.</pre></div>
<p>(so plasma pa is inconsistent with itself, and thus not the best place to draw conclusions from :/)</p>
<p>I'd like to see new ideas, I'm very reluctant to just inverse the meaning of a prominent icon that our userbase are now familiar with, it'll confuse everyone who's been using it for the past N years.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10032" rel="noreferrer">https://phabricator.kde.org/D10032</a></div></div><br /><div><strong>To: </strong>nicolasfella, Plasma, VDG<br /><strong>Cc: </strong>davidedmundson, broulik, ngraham, plasma-devel, VDG, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>