<table><tr><td style="">apol requested changes to this revision.<br />apol added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10023" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10023#inline-46001" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ApplicationPage.qml:157</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">                    <span style="color: #aa4000">text:</span> <span style="color: #004012">appInfo</span><span class="p">.</span><span style="color: #004012">application</span><span class="p">.</span><span style="color: #004012">name</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                    <span style="color: #aa4000">lineHeight:</span> <span style="color: #601200">1.0</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">                    <span style="color: #aa4000">maximumLineCount:</span> <span style="color: #601200">1</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">That's the default, no need to insist on it.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10023#inline-46002" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ApplicationPage.qml:167</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">                    <span style="color: #aa4000">maximumLineCount:</span> <span class="bright"></span><span style="color: #601200"><span class="bright">1</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                    <span style="color: #aa4000">maximumLineCount:</span> <span class="bright"></span><span style="color: #601200"><span class="bright">2</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                    <span style="color: #aa4000">lineHeight:</span> <span style="color: #004012">lineCount</span> <span style="color: #aa2211">></span> <span style="color: #601200">1</span> <span style="color: #aa2211">?</span> <span style="color: #601200">0.75</span> <span style="color: #aa2211">:</span> <span style="color: #601200">1.2</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">                    <span style="color: #aa4000">elide:</span> <span style="color: #004012">Text</span><span class="p">.</span><span style="color: #004012">ElideRight</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Is it really necessary? I wouldn't change the default at least to 1.2, leave 1.0 as it's the level 4 font.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R134 Discover Software Store</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10023" rel="noreferrer">https://phabricator.kde.org/D10023</a></div></div><br /><div><strong>To: </strong>ngraham, apol, Discover Software Store, VDG<br /><strong>Cc: </strong>plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>