<table><tr><td style="">tcberner added a comment.<br />Restricted Application edited projects, added KWin; removed Plasma.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9930" rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D9930#194036" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: line-through;" rel="noreferrer">D9930#194036</a>, <a href="https://phabricator.kde.org/p/graesslin/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@graesslin</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D9930#193993" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: line-through;" rel="noreferrer">D9930#193993</a>, <a href="https://phabricator.kde.org/p/tcberner/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@tcberner</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Hi there</p>
<p>This breaks the CI on FreeBSD, where we only have libinput 1.6</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">10:17:48 -- Could NOT find Libinput: Found unsuitable version "1.6.0", but required is at least "1.9" (found /usr/local/lib/libinput.so)
[...]
10:21:50 [ 71%] Building CXX object CMakeFiles/kwin_wayland.dir/main_wayland.cpp.o
10:21:50 /usr/home/jenkins/workspace/Plasma kwin kf5-qt5 FreeBSDQt5.9/tabletmodemanager.cpp:54:25: error: member access into incomplete type 'LibInput::Device'
10:21:50 if (!event->device()->isTabletModeSwitch()) {
10:21:50 ^
10:21:50 /usr/home/jenkins/workspace/Plasma kwin kf5-qt5 FreeBSDQt5.9/input_event.h:29:7: note: forward declaration of 'KWin::LibInput::Device'
10:21:50 class Device;
10:21:50 ^
10:21:51 1 error generated.
10:21:51 gmake[2]: *** [CMakeFiles/kwin_wayland.dir/build.make:63: CMakeFiles/kwin_wayland.dir/tabletmodemanager.cpp.o] Error 1
10:21:51 gmake[2]: *** Waiting for unfinished jobs....
10:21:51 [ 71%] Building CXX object plugins/platforms/virtual/CMakeFiles/KWinWaylandVirtualBackend.dir/virtual_backend.cpp.o
10:21:51 [ 71%] Linking CXX shared module ../../bin/org.kde.kglobalaccel5.platforms/KF5GlobalAccelPrivateKWin.so
10:21:51 /usr/home/jenkins/workspace/Plasma kwin kf5-qt5 FreeBSDQt5.9/plugins/platforms/virtual/egl_gbm_backend.cpp:239:19: warning: cast from 'uchar *' (aka 'unsigned char *') to 'uint *' (aka 'unsigned int *') increases required alignment from 1 to 4 [-Wcast-align]
10:21:51 uint *p = (uint*)img.bits();
10:21:51 ^~~~~~~~~~~~~~~~~
10:21:51 /usr/home/jenkins/workspace/Plasma kwin kf5-qt5 FreeBSDQt5.9/plugins/platforms/virtual/egl_gbm_backend.cpp:249:23: warning: cast from 'uchar *' (aka 'unsigned char *') to 'uint *' (aka 'unsigned int *') increases required alignment from 1 to 4 [-Wcast-align]
10:21:51 uint *q = (uint*)img.scanLine(y);
10:21:51 ^~~~~~~~~~~~~~~~~~~~~~
[...]</pre></div>
<p>So there seems to be some guarding missing as to what gets compiled without libinput.</p></div>
</blockquote>
<p>sorry about that . I was under the impression that libinput is incompatible with bsd.</p>
<p>Any chance to get 1.9? If yes I would like to make libinput a hard dependency as it was broken without anybody noticing for quite some time .</p></div>
</blockquote>
<p>I updated the FreeBSD CI image to have libinput-1.9.4 (based on a WIP update from FreeBSD's bugzilla).</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9930" rel="noreferrer">https://phabricator.kde.org/D9930</a></div></div><br /><div><strong>To: </strong>graesslin, KWin, Plasma, davidedmundson<br /><strong>Cc: </strong>tcberner, plasma-devel, kwin, iodelay, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart<br /></div>