<table><tr><td style="">hein retitled this revision from "Don't close plasmoid when closing a subdialog via index change in a parent subdialog" to "Don't close plasmoid when closing a subdialog".<br />hein edited the summary of this revision. <a href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-4w26a25sme7rhri/" rel="noreferrer">(Show Details)</a>
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9945" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>CHANGES TO REVISION SUMMARY</strong><div><div style="white-space: pre-wrap; color: #74777D;"><span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">Fixes a refactoring regression from 84f1cb1c1.<br />
<br />
There's an unrelated regression where the closing of a subdialog</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">This patch redoes the fencing mechanism around<br />
plasmoid.hideOnWindowDeactivate for window focus<br />
handovers to be more reliable and generic. It's now<br />
always disabled when a dialog is about to be<br />
destroyed, and renabled on focus-in or when exiting<br />
the root list. The dialog code is also fixed not<br />
to close the plasmoid when it knows it's window</span><br />
<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">of the root window by mousing to the favorites sidebar will</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">deactivation is part of its own destruction.<br />
<br />
WindowSystem::monitorWindowFocus is</span> also<span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);"> changed</span><br />
<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">cause the plasmoid to close.</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">to work in a single-shot sort of way,</span> <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">This will be addressed soon in a</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">removing</span><br />
<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">seperate patch</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">the event filter again once it caught an event</span>.<br />
<br />
<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">BUG: 388669</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">Fixes a refactoring regression from 84f1cb1c1.</span></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9945" rel="noreferrer">https://phabricator.kde.org/D9945</a></div></div><br /><div><strong>To: </strong>hein, Plasma<br /><strong>Cc: </strong>ngraham, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>