<table><tr><td style="">sebas accepted this revision.<br />sebas added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9463" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>I'm not suitable to review the X11 bits in here, but since you are the former maintainer, I trust you on those.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9463#inline-45305" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">config.h:69</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">PerOutputScaling</span> <span style="color: #aa2211">=</span> <span style="color: #601200">1</span> <span style="color: #aa2211"><<</span> <span style="color: #601200">2</span> <span style="color: #74777d">///< The backend supports scaling each output individually.</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">PerOutputScaling</span> <span style="color: #aa2211">=</span> <span style="color: #601200">1</span> <span style="color: #aa2211"><<</span> <span style="color: #601200">2<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span> <span style="color: #74777d">///< The backend supports scaling each output individually.</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">NonIntegerScaling</span> <span style="color: #aa2211">=</span> <span style="color: #601200">1</span> <span style="color: #aa2211"><<</span> <span style="color: #601200">3</span> <span style="color: #74777d">///< The backend supports scaling by non-integer factor</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="p">};</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I don't like the negation in the API, might as well tell what is does rather than what it doesn't do.</p>

<p style="padding: 0; margin: 8px;">FractionalScaling?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R110 KScreen Library</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9463" rel="noreferrer">https://phabricator.kde.org/D9463</a></div></div><br /><div><strong>To: </strong>dvratil, sebas, davidedmundson<br /><strong>Cc: </strong>ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>