<table><tr><td style="">jgrulich requested changes to this revision.<br />jgrulich added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9746" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Could you also add support for RSA SecurID so support for tokens is complete? I'm also not sure whether with this the support is complete, because you need to also add this to authentication dialog if I'm not mistaken.</p>

<p>See <a href="https://bugs.kde.org/show_bug.cgi?id=338650" class="remarkup-link" target="_blank" rel="noreferrer">https://bugs.kde.org/show_bug.cgi?id=338650</a>.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9746#inline-45099" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">openconnectwidget.cpp:111</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">ui</span><span class="p">.</span><span class="n">cmbProtocol</span><span style="color: #aa2211">-></span><span class="n">currentIndex</span><span class="p">()</span> <span style="color: #aa2211">!=</span> <span class="n">OpenconnectSettingWidgetPrivate</span><span style="color: #aa2211">::</span><span class="n">Disabled</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">ui</span><span class="p">.</span><span class="n">leTokenSecret</span><span style="color: #aa2211">-></span><span class="n">setText</span><span class="p">(</span><span class="n">secrets</span><span class="p">.</span><span class="n">value</span><span class="p">(</span><span class="n">NM_OPENCONNECT_KEY_TOKEN_SECRET</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Missing bracket at the end.</p></div></div></div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9746" rel="noreferrer">https://phabricator.kde.org/D9746</a></div></div><br /><div><strong>To: </strong>scarpino, jgrulich<br /><strong>Cc: </strong>plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>