<table><tr><td style="">romangg added a comment.<br />Restricted Application edited projects, added Plasma; removed KWin.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9848" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>I think we talked about your patch on IRC some time ago. I'm very happy that you decided to put it up here in Phab for review. Your Kawase blur looks really good in my opinion. That it is also faster makes it a no-brainer for me.</p>
<blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D9848#190128" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D9848#190128</a>, <a href="https://phabricator.kde.org/p/anemeth/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@anemeth</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Removed .arcconfig and added a whitespace</p></div>
</blockquote>
<p>What? Why?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9848#inline-44868" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">blur.h:29</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #304a96">#include</span> <span class="cpf"><QVector2D></span><span style="color: #304a96"></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">#include</span> <span class="cpf"><QtMath></span><span style="color: #304a96"></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Put this into the cpp.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9848#inline-44876" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">blur.h:92</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">void</span> <span style="color: #004012">uploadGeometry</span><span class="p">(</span><span class="n">GLVertexBuffer</span> <span style="color: #aa2211">*</span><span class="n">vbo</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QRegion</span> <span style="color: #aa2211">&<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">horizontal</span></span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QRegion</span> <span style="color: #aa2211">&<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">vertical</span></span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">void</span> <span style="color: #004012">uploadGeometry</span><span class="p">(</span><span class="n">GLVertexBuffer</span> <span style="color: #aa2211">*</span><span class="n">vbo</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QRegion</span> <span style="color: #aa2211">&<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">blurRegion</span></span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QRegion</span> <span style="color: #aa2211">&<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">renderRegion</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">const</span></span><span class="bright"> </span><span class="n"><span class="bright">QRegion</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">&</span></span><span class="bright"></span><span class="n"><span class="bright">windowRegion</span></span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">void</span> <span style="color: #004012">downSampleTexture</span><span class="p">(</span><span class="n">GLVertexBuffer</span> <span style="color: #aa2211">*</span><span class="n">vbo</span><span class="p">,</span> <span style="color: #aa4000">int</span> <span class="n">blurRectCount</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">There are many whitespace errors. If you're using KDevelop or Kate make sure that you have activated to automatically remove whitespace at the end of a line.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9848" rel="noreferrer">https://phabricator.kde.org/D9848</a></div></div><br /><div><strong>To: </strong>anemeth, Plasma, KWin<br /><strong>Cc: </strong>romangg, zzag, anthonyfieroni, mart, davidedmundson, fredrik, ngraham, plasma-devel, kwin, KWin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>